Support `placeholder` and other HTML5 attributes #464

Closed
int3 opened this Issue Jan 24, 2012 · 7 comments

Comments

Projects
None yet
3 participants
@int3
Collaborator

int3 commented Jan 24, 2012

Support the placeholder attribute when filtering for link hints. The user should be able to type the placeholder text to filter for the input box if the input box doesn't have a value.

This should be fairly easy to implement, and I'm happy to guide someone through the process.

@philc

This comment has been minimized.

Show comment Hide comment
@philc

philc Jan 24, 2012

Owner

To be clear, this is for the numeric link hints mode.

Owner

philc commented Jan 24, 2012

To be clear, this is for the numeric link hints mode.

@int3

This comment has been minimized.

Show comment Hide comment
@int3

int3 Jan 28, 2012

Collaborator

We should support aria-* attributes as well.

Collaborator

int3 commented Jan 28, 2012

We should support aria-* attributes as well.

@mhchen

This comment has been minimized.

Show comment Hide comment
@mhchen

mhchen Dec 16, 2012

Contributor

I'll work on this if no one else has worked/is working on it.

Contributor

mhchen commented Dec 16, 2012

I'll work on this if no one else has worked/is working on it.

@int3

This comment has been minimized.

Show comment Hide comment
@int3

int3 Dec 16, 2012

Collaborator

Yup, no one has picked it up so far. Go ahead!

Collaborator

int3 commented Dec 16, 2012

Yup, no one has picked it up so far. Go ahead!

@mhchen

This comment has been minimized.

Show comment Hide comment
@mhchen

mhchen Dec 17, 2012

Contributor

Sorry, I'm not totally clear on the spec for this. It looks like linkText has a 1-to-1 mapping with the element, and so it needs some kind of hierarchy. Currently it looks like it goes for the label first and then the value, and we're adding the placeholder after both of those. Where do the aria attributes fit in, and in what order?

Also, is this the best place to ask questions like this? Sorry I am still kind of new to OSS contributions. Thanks!

Contributor

mhchen commented Dec 17, 2012

Sorry, I'm not totally clear on the spec for this. It looks like linkText has a 1-to-1 mapping with the element, and so it needs some kind of hierarchy. Currently it looks like it goes for the label first and then the value, and we're adding the placeholder after both of those. Where do the aria attributes fit in, and in what order?

Also, is this the best place to ask questions like this? Sorry I am still kind of new to OSS contributions. Thanks!

@mhchen

This comment has been minimized.

Show comment Hide comment
@mhchen

mhchen Dec 19, 2012

Contributor

I added the placeholder support. As I mentioned in my above comment, I'm not totally sure how to handle the aria-* attributes. I considered looping through all aria-* attributes and pulling the first value that is not blank, but many aria-* attributes are just true/false booleans anyway so I don't see the value in this. I think supporting aria-* attributes would require a list of appropriate attributes to use.

Contributor

mhchen commented Dec 19, 2012

I added the placeholder support. As I mentioned in my above comment, I'm not totally sure how to handle the aria-* attributes. I considered looping through all aria-* attributes and pulling the first value that is not blank, but many aria-* attributes are just true/false booleans anyway so I don't see the value in this. I think supporting aria-* attributes would require a list of appropriate attributes to use.

@int3 int3 closed this in 8cbf158 Jan 2, 2013

int3 added a commit that referenced this issue Jan 2, 2013

Merge pull request #748 from mhchen/issue_464
Fix #464 - Support placeholder attribute for inputs in find mode
@int3

This comment has been minimized.

Show comment Hide comment
@int3

int3 Jan 2, 2013

Collaborator

Thanks @mhchen! As for the other aria- attributes... I think it might be useful to look into aria-label, aria-labelledby, and aria-describedby. We should first find sites that actually use them, before trying to support them in our hints system.

Collaborator

int3 commented Jan 2, 2013

Thanks @mhchen! As for the other aria- attributes... I think it might be useful to look into aria-label, aria-labelledby, and aria-describedby. We should first find sites that actually use them, before trying to support them in our hints system.

davidwallacejackson pushed a commit to davidwallacejackson/vimium that referenced this issue Apr 3, 2014

Fix #464 - Support placeholder attribute for inputs in find mode
Whereas find mode normally identifies inputs by their value, if a value
is blank, find mode will use the placeholder value instead, if it exists

davidwallacejackson pushed a commit to davidwallacejackson/vimium that referenced this issue Apr 3, 2014

Merge pull request #748 from mhchen/issue_464
Fix #464 - Support placeholder attribute for inputs in find mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment