Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Opening link in new tab using find results causes j or k to open random link #657

Closed
christophermanning opened this Issue · 4 comments

3 participants

@christophermanning

Steps to reproduce:

  • Go to https://status.github.com/ (or any other page) and press f to bring up finder
  • Hold shift and type a shortcut to open a tab in the background
  • Now, pressing j or k in the same tab will open a seemingly random link

I am using Vimium 1.39

OS: Ubuntu 11.04
Browser Version: 18.0.1025.151

@int3
Collaborator

That's odd... Can't reproduce it. Are you using the default Vimium config, or did you toggle any options?

Also, it's probably not relevant, but Chrome 18 seems a little outdated... I think 21 is the latest stable.

@christophermanning

I've unmap t since it breaks the github file search and removed f from the "Characters used for link hints" since my fingers think that f will close the link hints.

I am using Chrome 18 since it's the one that's in the ubuntu packages: http://packages.ubuntu.com/natty/chromium-browser

@hyh1048576

It's not a random link. It is the link marked by j or k the last time you hit "f".

@int3 int3 closed this issue from a commit
@int3 int3 Refactor handlerStack. Closes #657.
Previously, handlerStack was designed only for removal of the handler
right at the top of the stack. However, some handlers sought to remove
themselves when they were not at the top of the stack, creating
confusion. The new handlerStack ensures that such removal can always be
done safely.
ea73be1
@int3 int3 closed this in ea73be1
@christophermanning

Thank you!

@ForSpareParts ForSpareParts referenced this issue from a commit in ForSpareParts/vimium
@int3 int3 Refactor handlerStack. Closes #657.
Previously, handlerStack was designed only for removal of the handler
right at the top of the stack. However, some handlers sought to remove
themselves when they were not at the top of the stack, creating
confusion. The new handlerStack ensures that such removal can always be
done safely.
b170469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.