Vomnibar Can't trigger evernote's web clipper of JS-bookmarklet #710

Closed
UncleBill opened this Issue Nov 7, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@UncleBill
Contributor

UncleBill commented Nov 7, 2012

Some others are OK, like Google reader's JS-bookmarklt

Evernote's:

javascript:(function(){EN_CLIP_HOST='http://www.evernote.com';try{var%20x=document.createElement('SCRIPT');x.type='text/javascript';x.src=EN_CLIP_HOST+'/public/bookmarkClipper.js?'+(new%20Date().getTime()/100000);document.getElementsByTagName('head')[0].appendChild(x);}catch(e){location.href=EN_CLIP_HOST+'/clip.action?url='+encodeURIComponent(location.href)+'&title='+encodeURIComponent(document.title);}})();

Google reader's

javascript:var b=document.body;var GR________bookmarklet_domain='https://www.google.com';if(b&&!document.xmlVersion){void(z=document.createElement('script'));void(z.src='https://www.google.com/reader/ui/subscribe-bookmarklet.js');void(b.appendChild(z));}else{location='https://www.google.com/reader/view/feed/'+encodeURIComponent(location.href)}

P.S. Vimium run on Chrome 22.0.x /Windows 7-32bit

@smblott-github

This comment has been minimized.

Show comment Hide comment
@smblott-github

smblott-github Nov 7, 2012

Collaborator

What do you mean by "Can't trigger"?

Collaborator

smblott-github commented Nov 7, 2012

What do you mean by "Can't trigger"?

@UncleBill

This comment has been minimized.

Show comment Hide comment
@UncleBill

UncleBill Nov 7, 2012

Contributor

oh! sorry for that!
when I directly click on the bookmarklet, the js code will load a dialog div for page clipper,however calling the script via vomnibar get nothing( maybe some code has been embed in dom, but it does't run at all)

Contributor

UncleBill commented Nov 7, 2012

oh! sorry for that!
when I directly click on the bookmarklet, the js code will load a dialog div for page clipper,however calling the script via vomnibar get nothing( maybe some code has been embed in dom, but it does't run at all)

int3 added a commit that referenced this issue Nov 10, 2012

Inject bookmarklets by appending them as scripts.
This *should* fix the permission problems that `eval` faced.

Closes #575, #710.

@int3 int3 closed this Nov 10, 2012

davidwallacejackson pushed a commit to davidwallacejackson/vimium that referenced this issue Apr 3, 2014

Inject bookmarklets by appending them as scripts.
This *should* fix the permission problems that `eval` faced.

Closes #575, #710.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment