What look like two very small bugs ... #707

merged 2 commits into from Nov 9, 2012


None yet
3 participants

smblott-github commented Nov 5, 2012

Please see commits for details.
They're very small issues.

smblott-github added some commits Nov 5, 2012

Looks like missing parentheses.
This is looks wrong, and is inconsistent with the way the equivalent
calculation is handled elsewhere.

This commit fixes it.
Avoid empty query terms.
With the previous version, a query like "hello   there" yielded:
  [ "hello", "", "", "there" ]
as the queryTerms.

int3 added a commit that referenced this pull request Nov 9, 2012

@int3 int3 merged commit 8b09b85 into philc:master Nov 9, 2012

1 check passed

default The Travis build passed

This comment has been minimized.

Show comment Hide comment

philc Nov 11, 2012


Nice find.


philc commented Nov 11, 2012

Nice find.

davidwallacejackson pushed a commit to davidwallacejackson/vimium that referenced this pull request Apr 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment