Skip to content


Don't close link hints when shift is pressed #744

merged 1 commit into from

2 participants


When shift is pressed, it would close the link hints since shift doesn't match any links. Now it won't try matching when shift is pressed.

Fixes #697, but I'm not sure why it was working for me in an earlier version of Chromium.

@int3 int3 merged commit 0a06e93 into philc:master

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1 content_scripts/
2 content_scripts/
@@ -173,7 +173,7 @@ LinkHints =
# TODO(philc): Ignore keys that have modifiers.
if (KeyboardUtils.isEscape(event))
- else
+ else if (event.keyCode != keyCodes.shiftKey)
keyResult = @markerMatcher.matchHintsByKey(hintMarkers, event)
linksMatched = keyResult.linksMatched
delay = keyResult.delay ? 0
Something went wrong with that request. Please try again.