Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline for 1.0 final release #287

Open
edmorley opened this issue Feb 15, 2019 · 10 comments
Open

Timeline for 1.0 final release #287

edmorley opened this issue Feb 15, 2019 · 10 comments

Comments

@edmorley
Copy link
Contributor

Hi!

We're wanting to soon update to Django 2.1, however doing so requires that we update from django-filters 1.x to 2.x, which in turn throws up this pip warning:

djangorestframework-filters 0.10.2.post0 has requirement django-filter~=1.0, but you'll have django-filter 2.1.0 which is incompatible.

What steps are left before djangorestframework-filters 1.0 final is ready for release, and do you know roughly when that might be? :-)

Many thanks!

@rpkilby
Copy link
Collaborator

rpkilby commented Feb 15, 2019

Ach, the 1.0 release has been a long time coming. Only been working on it for ~3 years 😅

There are a couple of minor issues that need to be resolved, the only big ticket left is an overhaul of the docs, which is sorely needed.

That said, 1.0 is mostly ready, and I would recommend trying the 1.0.0.dev0 release.

  • Here are the few changes not included in the dev release.
  • Here is what's left on the milestone. Some of this might get bumped (e.g., issue 286).

@rpkilby
Copy link
Collaborator

rpkilby commented Feb 15, 2019

Just realizing the above is not a timeline. I'll take a stab at the docs this weekend, and see how far along I can get. That should give me an idea of how much time it should to get an actual 1.0 release out the door.

@edmorley
Copy link
Contributor Author

Thank you for the clarification, that helps :-)

@rpkilby
Copy link
Collaborator

rpkilby commented Feb 20, 2019

Quick question - are you able to use the 1.0 pre-release? Have you ran into any issues so far?

@edmorley
Copy link
Contributor Author

Sorry for the delayed reply. We since discovered that the features we were using are now all natively supported by django-filters, so were able to remove the dependency on django-rest-framework-filters, so never got as far as trying the 1.0 pre-release. Thank you anyway :-)

@markgajdosik
Copy link

Thought I'd comment that we're using 1.0.0-dev0 in production without any issues.

@rpkilby
Copy link
Collaborator

rpkilby commented Apr 9, 2019

Thanks - good to know. There are still a few bugs (like rendering the forms in the browsable API w/ crispy forms), but the 1.0 release should largely be ready.

@HansAarneLiblik
Copy link

Hey, 1.0 is still not released, but your docs currently state, that you're supporting django-filters 2.0, but pipenv graph states that you don't

djangorestframework-filters==0.11.1
  - django-filter [required: ~=1.1, installed: 1.1.0]
  - djangorestframework [required: Any, installed: 3.9.4]

@rpkilby
Copy link
Collaborator

rpkilby commented Jul 15, 2019

Hi @HansAarneLiblik. You either need to pip install -U --pre djangorestframework-filters or pip install djangorestframework-filters==1.0.0.dev0

@dralley
Copy link

dralley commented Jan 14, 2020

Hey @rpkilby :D I hope Portland is treating you well!

Do you expect that it will be ready for a release to PyPI soon? We would love to add some of these features to Pulp but adding a new dependency that has been pre-release for so long is a hard sell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants