django-notifications backend and a small optimization #10

Merged
merged 2 commits into from Feb 27, 2014

Conversation

Projects
None yet
2 participants
@tclancy
Contributor

tclancy commented Jun 14, 2013

This contains a back-end for django-notifications (mainly because I couldn't think of a better place to put it) and a small optimization where pynliner is only ever imported once instead of once per call to send in utils.py (at least I think that qualifies as an optimization).

@tclancy

This comment has been minimized.

Show comment
Hide comment
@tclancy

tclancy Jun 14, 2013

Contributor

Oops, looks like I just updated this pull request to include the threading I hacked in. Not sure if you want that or not. It does make things snappier and it's working in my project, but "works for me" on a Friday afternoon isn't much of a guarantee.

Contributor

tclancy commented Jun 14, 2013

Oops, looks like I just updated this pull request to include the threading I hacked in. Not sure if you want that or not. It does make things snappier and it's working in my project, but "works for me" on a Friday afternoon isn't much of a guarantee.

@philippWassibauer

This comment has been minimized.

Show comment
Hide comment
@philippWassibauer

philippWassibauer Feb 27, 2014

Owner

hi, sorry I did not see this. do you still need this? happy to merge it, but wanted to check in before I start reviewing

hi, sorry I did not see this. do you still need this? happy to merge it, but wanted to check in before I start reviewing

philippWassibauer added a commit that referenced this pull request Feb 27, 2014

Merge pull request #10 from tclancy/master
django-notifications backend and a small optimization

@philippWassibauer philippWassibauer merged commit 7c2de19 into philippWassibauer:master Feb 27, 2014

@tclancy

This comment has been minimized.

Show comment
Hide comment
@tclancy

tclancy Feb 27, 2014

Contributor

The project I built it for is dead (to me anyway), but I think it's worth having. Not sure about the "threading" bit though.

Contributor

tclancy commented Feb 27, 2014

The project I built it for is dead (to me anyway), but I think it's worth having. Not sure about the "threading" bit though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment