Here's a fix for the issue we've been talking about. #16

Merged
merged 4 commits into from Jun 8, 2011

Conversation

Projects
None yet
2 participants
Contributor

infiniteNIL commented Jun 6, 2011

Fixed https issue that caused Facebook authentication window to never go away and things would just basically be in limbo. It also properly handles the expiration seconds for the token. Getting a 0 for the expiry means there is no expiration. Before the case was not honoring this and the expiration seconds would become negative.

Nice! Thank you so much!

The magic numbers 7 and 8, do they correspond to the string length of "http://" and "https://"? If so, that should be documented, perhaps in a local constant.

Suggest "> 0" to be sure that we're in the future

Is this really necessary? If date is nil, won't [date timeIntervalSinceNow] be 0?

Awesome! Just a couple of minor nits.

Contributor

infiniteNIL commented Jun 7, 2011

Ok, I made those changes you suggested.

philippec added a commit that referenced this pull request Jun 8, 2011

Merge pull request #16 from infiniteNIL/master
Fixed https issue that caused Facebook authentication window to never go away.

Fixed https issue that caused Facebook authentication window to never go away and things would just basically be in limbo. It also properly handles the expiration seconds for the token. Getting a 0 for the expiry means there is no expiration. Before the case was not honoring this and the expiration seconds would become negative.

@philippec philippec merged commit 6e680fe into philippec:master Jun 8, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment