Completion blocks. #41

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
3 participants
@raffael

raffael commented Feb 21, 2013

  • Added the capability to define completion blocks for both token retrieval and requests. Defining a delegate is actually not necessary anymore.

Example:

fb = [[PhFacebook alloc] initWithApplicationID:@"XXXXXXX"];
[fb getAccessTokenForPermissions:@[@"publish_actions"] cached:NO withCompletionBlock:^(NSDictionary *result) {
    [fb sendRequest:@"/me" withCompletionBlock:^(NSDictionary *result) {
        NSLog(@"Got /me result: %@", result);
    }];
    [fb sendFQLRequest:@"SELECT uid, sex, name from user WHERE uid = me()" withCompletionBlock:^(NSDictionary *result) {
        NSLog(@"Got FQL result: %@", result);
    }];
}];
  • Added german .strings file
  • ARC compatibility
    WARNING: After refactoring for ARC, only 64bit is available

raffael added some commits Feb 19, 2013

@fjaeger

This comment has been minimized.

Show comment
Hide comment
@fjaeger

fjaeger Feb 28, 2013

I highly appreciate your work, but can't we have the completion blocks separately and discuss ARC in another pull request?

fjaeger commented Feb 28, 2013

I highly appreciate your work, but can't we have the completion blocks separately and discuss ARC in another pull request?

@raffael

This comment has been minimized.

Show comment
Hide comment
@raffael

raffael Feb 28, 2013

Our main goal was to extend PhFacebook with completion blocks as fast as possible for the (RMFBLayer project) [https://github.com/raffael-me/RMFBLayer], and since we're using ARC in all of our current projects, the ARC transformation was just a 'small cosmetical fix'.
I have to admit there are still lots of projects that do not make use of ARC!

raffael commented Feb 28, 2013

Our main goal was to extend PhFacebook with completion blocks as fast as possible for the (RMFBLayer project) [https://github.com/raffael-me/RMFBLayer], and since we're using ARC in all of our current projects, the ARC transformation was just a 'small cosmetical fix'.
I have to admit there are still lots of projects that do not make use of ARC!

@philippec

This comment has been minimized.

Show comment
Hide comment
@philippec

philippec Apr 3, 2016

Owner

Sunsetting the project. See README.md.

Owner

philippec commented Apr 3, 2016

Sunsetting the project. See README.md.

@philippec philippec closed this Apr 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment