Added parameters to sendRequest #6

Merged
merged 2 commits into from Apr 26, 2011

Projects

None yet

2 participants

@infiniteNIL
Contributor

Hi Phillip,

I needed to include some parameters to my friends request so I added a sendRequest:parameters method, changed sendRequest: to call sendRequest:parameters: and changed sendFacebookRequest: to use the parameters.

I think it would make a good addition as I'm sure others need to send parameters as well. I'm surprised it wasn't already there.

@philippec
Owner

Sounds great! Can you please adjust your patch so it matches the coding style of the surrounding functions? I think it's 2 spaces per tabs (no tabs), braces go on their own line and I'm a bit particular about the spacing for parameters and stuff. Just take a look at the rest and be consistent.

Thanks!

@infiniteNIL
Contributor

Ok, I adjusted the spacing and formatting.

@philippec
Owner

Thank you! Looks great. I will integrate as soon as I have a few moments to do it properly.

@philippec philippec added a commit that referenced this pull request Apr 26, 2011
@philippec Merged pull request #6 from infiniteNIL/master.
Added parameters to sendRequest
2b582fc
@philippec philippec merged commit 2b582fc into philippec:master Apr 26, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment