sticky-footer in IE + a few extras for #28#36
Conversation
|
Hey Marco, I'm happy to merge this in, but I'm a little hesitant to merge the utf-8 stuff and the .bowerrc file as they don't really seem needed to me. I know that |
|
Hi Phil, I actually have I'll purge those commits you mentioned and update the PR soon. |
|
Cool, this wasn't working for me in IE11, but I made a small change to the |
sticky-footer in IE + a few extras for #28
|
awesome 👍 |
|
For reference, here's the complete list of changes to make this work. I also updated the Holy Grail demo since technically that's a sticky footer layout as well. |
|
Nice :) |
|
I always use @support to handle IE in this issue. just make flexbox as an enhancement. |
|
FWIW, I'm no longer using the IE-only media query to do this. I've updated the |
|
Amazing @philipwalton ! My initial suggestion was Thanks a lot! |
Hi Philip,
So here’s a PR with a possible fix on the “sticky footer” IE behaviour regarding issue #28.
The fix is specified in commit cdfade5.
There are some few of extras too, including:
I had loads of outfit problems running this site locally
I had the bower components installed in components/ instead of bower_components/ adding a .bowerrc fixes this issue
Let me know what you think.