New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sticky-footer in IE + a few extras for #28 #36

Merged
merged 9 commits into from Dec 14, 2014

Conversation

Projects
None yet
3 participants
@marcobarbosa

marcobarbosa commented Dec 12, 2014

Hi Philip,

So here’s a PR with a possible fix on the “sticky footer” IE behaviour regarding issue #28.

The fix is specified in commit cdfade5.

There are some few of extras too, including:

  • some utf8 fixes
    I had loads of outfit problems running this site locally
  • .bowerrc file
    I had the bower components installed in components/ instead of bower_components/ adding a .bowerrc fixes this issue

Let me know what you think.

@philipwalton

This comment has been minimized.

Owner

philipwalton commented Dec 14, 2014

Hey Marco, I'm happy to merge this in, but I'm a little hesitant to merge the utf-8 stuff and the .bowerrc file as they don't really seem needed to me.

I know that bower_components is the default location for bower, so specifying it seems unnecessary. Also, isn't utf-8 the default in Ruby 2+? And even when I was using 1.9 I never got any encoding issues.

@marcobarbosa

This comment has been minimized.

marcobarbosa commented Dec 14, 2014

Hi Phil,

I actually have ruby 2.1.2 running and bower 1.3.12 so I'm not sure how to avoid those issues. Rake wouldn't work for me without fixing the utf8 and I'd get JS errors without .bowerrc. I might something weird with my setup then.

I'll purge those commits you mentioned and update the PR soon.

@philipwalton

This comment has been minimized.

Owner

philipwalton commented Dec 14, 2014

Cool, this wasn't working for me in IE11, but I made a small change to the flex declaration and it took, so I'll just do that myself. Thanks for letting me know about targeting IE with a media query!

philipwalton added a commit that referenced this pull request Dec 14, 2014

Merge pull request #36 from marcobarbosa/master
sticky-footer in IE + a few extras for #28

@philipwalton philipwalton merged commit 9ee8e68 into philipwalton:master Dec 14, 2014

@marcobarbosa

This comment has been minimized.

marcobarbosa commented Dec 14, 2014

awesome 👍

@philipwalton

This comment has been minimized.

Owner

philipwalton commented Dec 14, 2014

For reference, here's the complete list of changes to make this work. I also updated the Holy Grail demo since technically that's a sticky footer layout as well.

@marcobarbosa

This comment has been minimized.

marcobarbosa commented Dec 14, 2014

Nice :)

@kidwm

This comment has been minimized.

kidwm commented Jan 6, 2015

I always use @support to handle IE in this issue. just make flexbox as an enhancement.

@philipwalton

This comment has been minimized.

Owner

philipwalton commented Jan 6, 2015

FWIW, I'm no longer using the IE-only media query to do this. I've updated the .Site component based on some of my recent research.

@marcobarbosa

This comment has been minimized.

marcobarbosa commented Jan 7, 2015

Amazing @philipwalton !

My initial suggestion was height: 100% but you nailed it with the flex-shrink.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment