Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Performance noticeably worse after update to JSHint 1.1.0 and Rhino 1.7R4 #22

Open
danielellis opened this Issue Apr 4, 2013 · 3 comments

Comments

Projects
None yet
2 participants

When I ran with version 0.3.4 / r12, hinting my project took ~10 seconds.

When I run the nodejs version of jshint 1.1.0, hinting my project also takes ~10 seconds.

With version 0.3.6-SNAPSHOT / 1.1.0 via ant, hinting my project takes ~2 minutes.

Owner

philmander commented Apr 10, 2013

I made a bad decision to include env.js briefly to better emulate a browser environment in Rhino (it was overkill to use it). This may well be slowing things down alot, I removed it, but I think I might have forgotten to push the latest snapshot jar though with env.js removed.

Could you check the latest jar in the release directory.

I'm seeing the same results. I noticed that in your last commit, you deleted a file but didn't update anything. Was there a file missing from the commit? :)

ede60c0

Hmm I built locally with mvn package and copied over the new file. I'm still seeing the same results. I'd be happy to profile it if you have instructions on how to do so. If I get some spare time, then I'll figure out how myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment