Skip to content

Fixed Icicle request loading (and maybe broke something else)#87

Merged
philogb merged 5 commits into
philogb:masterfrom
Jyrsa:master
Nov 2, 2011
Merged

Fixed Icicle request loading (and maybe broke something else)#87
philogb merged 5 commits into
philogb:masterfrom
Jyrsa:master

Conversation

@Jyrsa

@Jyrsa Jyrsa commented Oct 24, 2011

Copy link
Copy Markdown

Hi,

The dynamic requesting in Icicle was broken and I fixed it so that it works for me (tm).

b07e564 was a straightforward carelessness error in refactoring and I fixed that.

b892441 broke stuff for me but I'm not 100% sure why. Might want to take a look at it.

The rest are just adding a simple dynamic example to Icicle.

If you want a peek of the changes in action, http://jyrsa.iki.fi/jyrsa/helmet/ is my entry to Apps4Finland (an open data contest in Finland).

Regards,
Jyrsa

@philogb

philogb commented Nov 2, 2011

Copy link
Copy Markdown
Owner

Hi Thanks for your fixes! What do you mean with b892441 broke stuff for me but I'm not 100% sure why: do you mean that the commit fixed something that was triggering problems for you or that this specific commit breaks some examples ?

@philogb

philogb commented Nov 2, 2011

Copy link
Copy Markdown
Owner

Thanks also for providing a test case! :)

philogb added a commit that referenced this pull request Nov 2, 2011
Fixed Icicle request loading (and maybe broke something else)
@philogb philogb merged commit 4ad7202 into philogb:master Nov 2, 2011
@Jyrsa

Jyrsa commented Nov 2, 2011

Copy link
Copy Markdown
Author

b892441 removed a few lines that gave me errors. Apparently at some times this.config was null so evaluating this.config.constrained obviously led to an error.

All the examples seemed to work after removing those lines but I don't know if I missed something or if you have a grand plan or somesuch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants