Fixed Icicle request loading (and maybe broke something else)#87
Merged
Conversation
Owner
|
Hi Thanks for your fixes! What do you mean with |
Owner
|
Thanks also for providing a test case! :) |
philogb
added a commit
that referenced
this pull request
Nov 2, 2011
Fixed Icicle request loading (and maybe broke something else)
Author
|
b892441 removed a few lines that gave me errors. Apparently at some times this.config was null so evaluating this.config.constrained obviously led to an error. All the examples seemed to work after removing those lines but I don't know if I missed something or if you have a grand plan or somesuch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The dynamic requesting in Icicle was broken and I fixed it so that it works for me (tm).
b07e564 was a straightforward carelessness error in refactoring and I fixed that.
b892441 broke stuff for me but I'm not 100% sure why. Might want to take a look at it.
The rest are just adding a simple dynamic example to Icicle.
If you want a peek of the changes in action, http://jyrsa.iki.fi/jyrsa/helmet/ is my entry to Apps4Finland (an open data contest in Finland).
Regards,
Jyrsa