From 3fd84b0fa847484370f98cb1e2a90b159b4d64e4 Mon Sep 17 00:00:00 2001
From: Philippe Bourgau <philippe.bourgau@gmail.com>
Date: Sat, 10 Jun 2017 07:09:25 +0200
Subject: [PATCH] Fix estimates buttons on small mobile phones

In order to display well on mobile screens
- replace width by max-width in css for buttons form
- increase the line spacing in the buttons form
- change an html id from Session to session
- add correct html id for buttons form
---
 DayBook.md                            | 53 ++++-----------------------
 app/assets/stylesheets/custom.scss    |  6 ++-
 app/views/static_pages/home.html.erb  |  2 +-
 app/views/votes/_running.html.erb     | 10 ++---
 features/step_definitions/homepage.rb |  2 +-
 5 files changed, 19 insertions(+), 54 deletions(-)

diff --git a/DayBook.md b/DayBook.md
index 2f8735a..11fd42d 100644
--- a/DayBook.md
+++ b/DayBook.md
@@ -1,43 +1,14 @@
 # TODO Release Alpha
 
-* ~~Doc / home page
-    * ~~Explain what's the need
-    * how to use it~~
-    * ~~where it's available
-    * limitations
-    * explain it's open source, with the licence, and that instructions can be found in the repo
-    * links to the different parts
-        * the app
-        * repo
-        * author
-    * Ask for feedback~~
-* ~~readme
-    * ~~link badges
-      * heroku live
-      * zenhub issues
-    * what it does
-      * ~~the vision~~
-    * ~~run it~~
-      * ~~how it is deployed~~
-      * ~~how to deploy it yourself~~
-    * ~~how to contribute
-      * issue board
-      * the 'CI'
-      * coding conventions
-        * TDD
-        * few mocks
-        * follow standards
-        * simplest things
-        * TODOs for technical debt (esp at beginning)~~
 * The video
-    * write down a script
+    * ~~write down a script~~
       * Hi
       * goal : demo remote planning poker with philou's planning poker app
       * imagine the toons team 3 members : Jerry, Tom and Coyote
       * all different place, all different sessions
       * they start a phone conference
       * they all go to the planning poker homepage
-      * jerry enters first
+      * jerry enters first -> animator
       * followed by Tom
       * they discuss and agree to start estimating a story
       * Tom votes 5
@@ -51,25 +22,17 @@
       * twice as many 3s than 5s
       * Discussion
       * Could re-vote or vote another story
-    * setup obs
-      * does not seem to work on retina display
-      * I'll have to try the quick time stuff
+      * that's all for the demo
+      * find it live on heroku, repeat url
+    * ~~setup quick time~~
     * record it
     * push it to youtube
     * add it to readme
     * add it to the homepage
-* ~~links at the bottom:
-    * the author, my blog
-    * repo, open source
-    * a doc page
-    * push~~
-~~* make it responsive !
-    * check the work needed~~
-* v0.1
 * publish the homepage to social media
-    * is it published through my rss ?
-    * twitter ?
-    * hackernews
+    * ~~is it published through my rss ?~~ NO
+    * twitter ? My latest #SideProject, a remote #PlanningPoker app #agile
+    * hackernews [Show HN] Open Source remote planning poker app
 
 # Next Stories
 # Smells
diff --git a/app/assets/stylesheets/custom.scss b/app/assets/stylesheets/custom.scss
index a400a6f..9269b37 100644
--- a/app/assets/stylesheets/custom.scss
+++ b/app/assets/stylesheets/custom.scss
@@ -53,7 +53,7 @@ p {
 /* Custom element alignment */
 
 #team-vote-countdown {
-    width: 400px;
+    max-width: 400px;
     margin-left: auto;
     margin-right: auto;
 }
@@ -64,4 +64,8 @@ p {
 
 #estimate-histograms {
   margin: 2em auto;
+}
+
+#estimates-buttons {
+  line-height: 275%;
 }
\ No newline at end of file
diff --git a/app/views/static_pages/home.html.erb b/app/views/static_pages/home.html.erb
index 6d127f5..d7b90bf 100644
--- a/app/views/static_pages/home.html.erb
+++ b/app/views/static_pages/home.html.erb
@@ -5,7 +5,7 @@
   <h1>Philou's Planning Poker</h1>
   <p>A planning poker app for agile remote teams</p>
 
-  <%= form_tag contributors_path, id: "Session", class: "form-inline" do %>
+  <%= form_tag contributors_path, id: "session", class: "form-inline" do %>
     <%= text_field_tag "Team", "", class: "form-control", placeholder:"Your team" %>
     <%= text_field_tag "Name", "", class: "form-control", placeholder: "Your name" %>
     <%= submit_tag "Enter", class: "btn btn-default" %>
diff --git a/app/views/votes/_running.html.erb b/app/views/votes/_running.html.erb
index d91fd98..0e20433 100644
--- a/app/views/votes/_running.html.erb
+++ b/app/views/votes/_running.html.erb
@@ -6,15 +6,13 @@
      <div class="lead">
        <span id="team-vote-clock" data-vote-ending="<%= vote.ending.iso8601 %>"><%= pluralize(vote.seconds_to_end, "second") %></span> remaining
      </div>
-     <%= form_tag contributor_estimations_path(@contributor), id: "Session", class: "form-inline" do %>
+     <%= form_tag contributor_estimations_path(@contributor), id: "estimates-buttons", class: "form-inline" do %>
 
-       <div class="btn-group">
-         <% PhilousPlanningPoker::FIBOS.each do |estimate| %>
+       <% PhilousPlanningPoker::FIBOS.each do |estimate| %>
 
-           <%= submit_tag estimate, class: "btn btn-primary", name: "story_points" %>
+         <%= submit_tag estimate, class: "btn btn-primary", name: "story_points" %>
 
-         <% end %>
-       </div>
+       <% end %>
 
      <% end %>
 
diff --git a/features/step_definitions/homepage.rb b/features/step_definitions/homepage.rb
index 584b599..8443ce4 100644
--- a/features/step_definitions/homepage.rb
+++ b/features/step_definitions/homepage.rb
@@ -1,7 +1,7 @@
 def enter_team_space(contributor_name, team_name)
   visit root_path
 
-  within("#Session") do
+  within("#session") do
     fill_in 'Team', :with => team_name
     fill_in 'Name', :with => contributor_name
   end