Phil Whelan philwhln

Organizations

@ActiveState
philwhln commented on pull request jenkinsci/cloudfoundry#7
@philwhln

Code is submitted with tabs for indentation, but existing code uses spaces.

@philwhln
  • @philwhln 4a595b2
    301079 - bump aok usage of kato
philwhln commented on commit ActiveState/aok@6b47c9a6a0
@philwhln

LGTM

@philwhln

Thanks!

@philwhln

Precompiled tars for lucid and trust vendor/nginx-1.7.4-lucid.tar.gz vendor/nginx-1.7.4-trusty.tar.gz How were these generated?

philwhln commented on commit ActiveState/aok@be6e4d7617
@philwhln

Does this need to @server instead of server, since it's not a instance variable? Should still be in scope for the below references.

@philwhln
@philwhln
@philwhln
  • @philwhln 61900de
    300456 - Add Apache License Version 2.0
@philwhln
Link to "officially support list of buildpack" broken
philwhln commented on commit ActiveState/aok@c2209aeda8
@philwhln

LGTM

@philwhln

Needs reverting

@philwhln

Do we need to the retry logic to be so complicated? Just trying once per second should be fine.

@philwhln
More info in the README
@philwhln

Hi @ematpl, Thanks for the extra info! binaries run as separate processes inside the docker container Is this repo for actually working with Dock…

@philwhln

(It ends up that we don't actually use this functionality anymore; found somewhere better for it.) Awesome! I guess I should reset dev to not in…

@philwhln

How are HTTP errors handled if we're not using http.errback { f.resume(http) }? How does this connection get cleaned up if it never times out? Or i…

@philwhln
@philwhln master is now d88c707