Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker instructions #1087

Merged
merged 2 commits into from Jul 7, 2019
Merged

Update docker instructions #1087

merged 2 commits into from Jul 7, 2019

Conversation

xu-li
Copy link
Contributor

@xu-li xu-li commented Jul 3, 2019

The options to docker run command should be passed before the image.

Reference.

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #1087 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1087   +/-   ##
=========================================
  Coverage     46.74%   46.74%           
  Complexity    10069    10069           
=========================================
  Files           506      506           
  Lines         24610    24610           
=========================================
  Hits          11504    11504           
  Misses        13106    13106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2758c...1c7e770. Read the comment docs.

@siad007 siad007 added this to the 3.0.0-alpha3 milestone Jul 7, 2019
@siad007 siad007 merged commit bcc11c8 into phingofficial:master Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants