Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from PhingFile to SplFileObject - part 1 #1178

Merged
merged 5 commits into from Oct 28, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Oct 26, 2019

  • removed unused methods
  • moved some general PhingFile stuff to the FileUtils
  • started to use SplFileObject (part 1)

@siad007 siad007 added this to the 3.0.0-alpha4 milestone Oct 26, 2019
@codecov
Copy link

codecov bot commented Oct 27, 2019

Codecov Report

Merging #1178 into master will increase coverage by 0.24%.
The diff coverage is 62.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1178      +/-   ##
============================================
+ Coverage     47.13%   47.37%   +0.24%     
+ Complexity     9971     9939      -32     
============================================
  Files           505      505              
  Lines         24484    24414      -70     
============================================
+ Hits          11540    11567      +27     
+ Misses        12944    12847      -97
Impacted Files Coverage Δ Complexity Δ
classes/phing/system/io/WindowsFileSystem.php 3.8% <ø> (+0.34%) 106 <0> (-10) ⬇️
classes/phing/system/io/UnixFileSystem.php 82.22% <ø> (+11.06%) 44 <0> (-7) ⬇️
...phing/tasks/ext/zendguard/ZendGuardLicenseTask.php 0% <0%> (ø) 55 <0> (ø) ⬇️
classes/phing/parser/ExpatParser.php 80.64% <0%> (ø) 9 <0> (+1) ⬆️
classes/phing/tasks/ext/WikiPublishTask.php 48.71% <0%> (ø) 52 <0> (ø) ⬇️
classes/phing/Diagnostics.php 0% <0%> (ø) 20 <0> (ø) ⬇️
classes/phing/tasks/ext/property/PathToFileSet.php 0% <0%> (ø) 18 <0> (ø) ⬇️
classes/phing/tasks/ext/RSTTask.php 99.18% <100%> (ø) 38 <0> (ø) ⬇️
classes/phing/mappers/CutDirsMapper.php 92.85% <100%> (ø) 7 <0> (ø) ⬇️
classes/phing/util/DirectoryScanner.php 73.33% <100%> (ø) 101 <0> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89abc8a...96e97b7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup core
Development

Successfully merging this pull request may close these issues.

None yet

1 participant