Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added posix permission selector #1209

Merged
merged 19 commits into from Dec 24, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Dec 15, 2019

POSIX permission selector based on fileperms() with permission mode octal (i.e. 750) or with a string (i.e. 'rwxrwxrwx').

@siad007 siad007 added this to the 3.0.0-alpha4 milestone Dec 15, 2019
@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #1209 into master will increase coverage by 0.04%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1209      +/-   ##
============================================
+ Coverage     47.39%   47.43%   +0.04%     
- Complexity     9964     9973       +9     
============================================
  Files           506      507       +1     
  Lines         24485    24515      +30     
============================================
+ Hits          11604    11629      +25     
- Misses        12881    12886       +5
Impacted Files Coverage Δ Complexity Δ
...ses/phing/tasks/ext/phpunit/PHPUnitTestRunner8.php 0% <0%> (ø) 58 <0> (ø) ⬇️
classes/phing/types/selectors/SelectorAware.php 28.07% <0%> (-1.03%) 28 <1> (+1)
...ses/phing/tasks/ext/phpunit/PHPUnitTestRunner7.php 58.82% <100%> (+0.7%) 58 <0> (+1) ⬆️
...phing/types/selectors/PosixPermissionsSelector.php 92% <92%> (ø) 7 <7> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d874743...1b850e8. Read the comment docs.

@siad007 siad007 changed the title [WIP] Added posix permission selector Added posix permission selector Dec 22, 2019
@siad007 siad007 merged commit 50d9440 into phingofficial:master Dec 24, 2019
@siad007 siad007 deleted the PosixPermissionSelector branch December 24, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant