Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyTask] Added "required" attribute #1226

Merged
merged 7 commits into from Dec 28, 2019
Merged

[PropertyTask] Added "required" attribute #1226

merged 7 commits into from Dec 28, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Dec 27, 2019

Whether the build should fail on missing property file.

Whether the build should fail on missing property file.
Changed attribute name to required - see XmlPropertyTask
@siad007 siad007 changed the title [PropertyTask] Added failOnError attribute [PropertyTask] Added "required" attribute Dec 28, 2019
@siad007 siad007 added this to the 3.0.0-alpha4 milestone Dec 28, 2019
@codecov
Copy link

codecov bot commented Dec 28, 2019

Codecov Report

Merging #1226 into master will increase coverage by 0.03%.
The diff coverage is 80.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1226      +/-   ##
============================================
+ Coverage     47.43%   47.47%   +0.03%     
+ Complexity     9973     9967       -6     
============================================
  Files           507      507              
  Lines         24515    24505      -10     
============================================
+ Hits          11629    11633       +4     
+ Misses        12886    12872      -14
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/XmlPropertyTask.php 0% <ø> (ø) 12 <0> (-8) ⬇️
classes/phing/tasks/system/PropertyTask.php 79.53% <80.95%> (-0.47%) 75 <14> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d9440...13f5f0d. Read the comment docs.

@siad007 siad007 merged commit 054c72c into master Dec 28, 2019
@siad007 siad007 deleted the siad007-patch-1 branch December 28, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant