Detect rsync remote connection using colon #288

Merged
merged 4 commits into from Jun 23, 2014

Conversation

Projects
None yet
2 participants
@splinter89
Contributor

splinter89 commented Jun 4, 2014

I updated FileSyncTask so it can detect remote connection w/o specification of user in destinationDir or sourceDir.
According to rsync manual, they both can be in the following formats: [USER@]HOST:SRC, [USER@]HOST::SRC, [USER@]HOST:DEST, [USER@]HOST::DEST
As we can see, "USER@" part is optional.

@splinter89 splinter89 changed the title from detect rsync remote connection using colon to Detect rsync remote connection using colon Jun 5, 2014

@mrook

This comment has been minimized.

Show comment Hide comment
@mrook

mrook Jun 9, 2014

Member

Thanks! Could you update the applicable documentation as well?

Member

mrook commented Jun 9, 2014

Thanks! Could you update the applicable documentation as well?

@splinter89

This comment has been minimized.

Show comment Hide comment
@splinter89

splinter89 Jun 10, 2014

Contributor

I also definitely need help with updating output for docs..

Contributor

splinter89 commented Jun 10, 2014

I also definitely need help with updating output for docs..

@mrook

This comment has been minimized.

Show comment Hide comment
@mrook

mrook Jun 10, 2014

Member

Generating the output is definitely not painless, but I can generate those after the merge. Thanks for the update!

Member

mrook commented Jun 10, 2014

Generating the output is definitely not painless, but I can generate those after the merge. Thanks for the update!

mrook added a commit that referenced this pull request Jun 23, 2014

Merge pull request #288 from splinter89/fix-rsync-remote-detection
Detect rsync remote connection using colon

@mrook mrook merged commit 4817868 into phingofficial:master Jun 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@splinter89 splinter89 deleted the splinter89:fix-rsync-remote-detection branch Jun 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment