#1108 fix for pdosqlexec doesn't throw exception #290

Merged
merged 1 commit into from Jun 25, 2014

2 participants

@corretge

Fix for pdosqlexec doesn't throw exception for the non-first SQL instruction.

http://www.phing.info/trac/ticket/1108

When pdosqlexec task process a dbdeploy file and we have a wrong SQL instruction but not the first instruction, PDO doesn't throw exception as explained in this bug ​https://bugs.php.net/bug.php?id=61613

To skip this bug, we can split the SQL file for a instruction for each delimiter.

Adding this control in DummyPDOQuerySplitter it works like a charm, the MySQL errors are showed.

@corretge corretge #1108 fix for pdosqlexec doesn't throw exception
Fix for pdosqlexec doesn't throw exception for the non-first SQL instruction.

http://www.phing.info/trac/ticket/1108

When pdosqlexec task process a dbdeploy file and we have a wrong SQL instruction but not the first instruction, PDO doesn't throw exception as explained in this bug ​https://bugs.php.net/bug.php?id=61613

To skip this bug, we can split the SQL file for a instruction for each delimiter.

Adding this control in DummyPDOQuerySplitter it works like a charm, the MySQL errors are showed.
0671a32
@mrook mrook merged commit 01b3f50 into phingofficial:master Jun 25, 2014

1 check passed

Details continuous-integration/travis-ci The Travis CI build passed
@corretge corretge deleted the corretge:patch-1 branch Jul 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment