New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove S3 PEAR dependency #302

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@floriansemm

floriansemm commented Aug 22, 2014

In order to use the phing.phar without any dependencies to PEAR, I have refactored the S3PutTask and S3GetTask. Both tasks use the AWS SDK to put and get files from S3.

@mrook

This comment has been minimized.

Show comment
Hide comment
@mrook

mrook Aug 31, 2014

Member

Thanks for the pr @floriansemm. Can you please refactor it so it's PHP 5.2 compatible?

Member

mrook commented Aug 31, 2014

Thanks for the pr @floriansemm. Can you please refactor it so it's PHP 5.2 compatible?

@floriansemm

This comment has been minimized.

Show comment
Hide comment
@floriansemm

floriansemm Sep 1, 2014

I don't if a php52 support is possible, because the AWS SDK is build for 5.3+.

Maybe it is time to skip the php52 support (php56 is already released) and old dependencies to PEAR

floriansemm commented Sep 1, 2014

I don't if a php52 support is possible, because the AWS SDK is build for 5.3+.

Maybe it is time to skip the php52 support (php56 is already released) and old dependencies to PEAR

@mrook

This comment has been minimized.

Show comment
Hide comment
@mrook

mrook Sep 1, 2014

Member

There are still plenty of 5.2 installations... It's definitely on the roadmap though (http://www.phing.info/trac/ticket/1098), but it will not happen overnight - and will require a major version increase.

Member

mrook commented Sep 1, 2014

There are still plenty of 5.2 installations... It's definitely on the roadmap though (http://www.phing.info/trac/ticket/1098), but it will not happen overnight - and will require a major version increase.

@floriansemm

This comment has been minimized.

Show comment
Hide comment
@floriansemm

floriansemm Sep 2, 2014

Sure it's not a small change.

So let's a 3.0 branch and start the work.

floriansemm commented Sep 2, 2014

Sure it's not a small change.

So let's a 3.0 branch and start the work.

@mrook

This comment has been minimized.

Show comment
Hide comment
@mrook

mrook Sep 3, 2014

Member

Agreed. There is a branch "unstable-3.0", but that one's hopelessly outdated and needs a (lengthy) rebase.

Member

mrook commented Sep 3, 2014

Agreed. There is a branch "unstable-3.0", but that one's hopelessly outdated and needs a (lengthy) rebase.

@floriansemm

This comment has been minimized.

Show comment
Hide comment
@floriansemm

floriansemm Sep 4, 2014

Is it worth to rebase the branch? What is in a v3.0 release included?

floriansemm commented Sep 4, 2014

Is it worth to rebase the branch? What is in a v3.0 release included?

@mrook

This comment has been minimized.

Show comment
Hide comment
@mrook

mrook Sep 4, 2014

Member

See http://www.phing.info/trac/milestone/3.0, some work has been done on that branch a year or two ago.

Member

mrook commented Sep 4, 2014

See http://www.phing.info/trac/milestone/3.0, some work has been done on that branch a year or two ago.

@mrook mrook modified the milestone: 3.0 Dec 2, 2014

@mrook

This comment has been minimized.

Show comment
Hide comment
@mrook

mrook Oct 7, 2016

Member

Could you rebase this PR against branch 3.0?

Member

mrook commented Oct 7, 2016

Could you rebase this PR against branch 3.0?

siad007 added a commit to siad007/phing that referenced this pull request Aug 5, 2017

@mrook mrook closed this in #748 Aug 24, 2017

mrook added a commit that referenced this pull request Aug 24, 2017

@floriansemm floriansemm deleted the floriansemm:remove_aws_dependency branch Aug 25, 2017

matyasb pushed a commit to matyasb/phing that referenced this pull request Aug 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment