From b0191b68f7a616e658e5de2c398c7fcdaac38132 Mon Sep 17 00:00:00 2001 From: Fujimoto Seiji Date: Tue, 24 Dec 2019 07:05:16 +0900 Subject: [PATCH] revert "out_kafka: make MSVC compatible (#1179)" (#1832) This reverts commit 69fffab96630869015437a6d1d13aa1efeb0a9c7. Bakashar Kemerbay (and many other Windows users) reports that it causes an immediate abort on Windows environments. In particular, it causes abort even when they does not use out_kafka. For example, I can confirm that even the following command does not work on a vanilla Windows server. $ fluent-bit.exe -i dummy -o stdout This is because librdkafka is dependent on OpenSSL (ssleay32.dll and libeay32.dll), which most Windows servers do not have. Hence fluent-bit.exe always fails due to missing DLL dependencies. So we have to revert this, and revisit it after resolving the dependency issue. Signed-off-by: Fujimoto Seiji --- cmake/windows-setup.cmake | 2 +- plugins/out_kafka/CMakeLists.txt | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cmake/windows-setup.cmake b/cmake/windows-setup.cmake index 391f738b7e5..a021950ff9a 100644 --- a/cmake/windows-setup.cmake +++ b/cmake/windows-setup.cmake @@ -63,7 +63,7 @@ set(FLB_OUT_STDOUT Yes) set(FLB_OUT_LIB No) set(FLB_OUT_NULL Yes) set(FLB_OUT_FLOWCOUNTER Yes) -set(FLB_OUT_KAFKA Yes) +set(FLB_OUT_KAFKA No) set(FLB_OUT_KAFKA_REST No) # FILTER plugins diff --git a/plugins/out_kafka/CMakeLists.txt b/plugins/out_kafka/CMakeLists.txt index b8aff9ff4b6..30303fb91c1 100644 --- a/plugins/out_kafka/CMakeLists.txt +++ b/plugins/out_kafka/CMakeLists.txt @@ -16,6 +16,4 @@ set(src kafka.c) FLB_PLUGIN(out_kafka "${src}" "rdkafka") -if (NOT MSVC) - target_link_libraries(flb-plugin-out_kafka -lpthread) -endif() +target_link_libraries(flb-plugin-out_kafka -lpthread)