From 2945dd7a51a6acac614a66d9af84269bf9abf4f2 Mon Sep 17 00:00:00 2001 From: Ryan Hamilton Date: Thu, 7 Mar 2024 02:29:48 -0800 Subject: [PATCH] http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (#32751) http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false A number of users have reported issues with oghttp2 including #32611 and #32401 so reverting this flag seems wise. Signed-off-by: Ryan Hamilton --- changelogs/current.yaml | 5 +++++ source/common/runtime/runtime_features.cc | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/changelogs/current.yaml b/changelogs/current.yaml index 61fc804b4e27..d9a2d038fc33 100644 --- a/changelogs/current.yaml +++ b/changelogs/current.yaml @@ -2,6 +2,11 @@ date: Pending behavior_changes: # *Changes that are expected to cause an incompatibility if applicable; deployment changes are likely required* +- area: http2 + change: | + Changes the default value of ``envoy.reloadable_features.http2_use_oghttp2`` to ``false``. This changes the codec used for HTTP/2 + requests and responses. A number of users have reported issues with oghttp2 including issue 32611 and issue 32401 This behavior + can be reverted by setting the feature to ``true``. minor_behavior_changes: # *Changes that may cause incompatibilities for some users, but should not for most* diff --git a/source/common/runtime/runtime_features.cc b/source/common/runtime/runtime_features.cc index ba85f5394806..30a6c598bb5d 100644 --- a/source/common/runtime/runtime_features.cc +++ b/source/common/runtime/runtime_features.cc @@ -56,7 +56,6 @@ RUNTIME_GUARD(envoy_reloadable_features_http1_connection_close_header_in_redirec RUNTIME_GUARD(envoy_reloadable_features_http1_use_balsa_parser); RUNTIME_GUARD(envoy_reloadable_features_http2_decode_metadata_with_quiche); RUNTIME_GUARD(envoy_reloadable_features_http2_discard_host_header); -RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2); RUNTIME_GUARD(envoy_reloadable_features_http2_validate_authority_with_quiche); RUNTIME_GUARD(envoy_reloadable_features_http_allow_partial_urls_in_referer); RUNTIME_GUARD(envoy_reloadable_features_http_filter_avoid_reentrant_local_reply); @@ -100,6 +99,10 @@ RUNTIME_GUARD(envoy_restart_features_send_goaway_for_premature_rst_streams); RUNTIME_GUARD(envoy_restart_features_udp_read_normalize_addresses); // Begin false flags. These should come with a TODO to flip true. + +// TODO(birenroy) Flip this to true after resolving issues. +// Ignore the automated "remove this flag" issue: we should keep this for 1 year. +FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2); // Sentinel and test flag. FALSE_RUNTIME_GUARD(envoy_reloadable_features_test_feature_false); // TODO(paul-r-gall) Make this enabled by default after additional soak time.