Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable with sf 4 #5

Merged
merged 3 commits into from Feb 16, 2018

Conversation

Projects
None yet
2 participants
@andreybolonin
Copy link
Contributor

andreybolonin commented Feb 12, 2018

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 12, 2018

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #5   +/-   ##
======================================
  Coverage    66.9%   66.9%           
======================================
  Files           2       2           
  Lines         142     142           
======================================
  Hits           95      95           
  Misses         47      47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d54ccc...5cc9d3b. Read the comment docs.

@qubit05

This comment has been minimized.

Copy link
Contributor

qubit05 commented Feb 16, 2018

Hi @andreybolonin Thanks for the contribution. Happy to make these changes. The only thing I'm not sure of is changing the PHP version dependency to >= 5.6 as that would require a new major release. Is this needed specifically? Although I do notice this then matches the travis file.

@andreybolonin

This comment has been minimized.

Copy link
Contributor Author

andreybolonin commented Feb 16, 2018

@qubit05 no, it is not required for Symfony 4.

@qubit05 qubit05 merged commit b0ff5c4 into phlib:master Feb 16, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 1d54ccc...5cc9d3b
Details
codecov/project 66.9% remains the same compared to 1d54ccc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.