Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: choice questions return index, not value #62

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@weierophinney
Copy link
Contributor

weierophinney commented Nov 7, 2019

When you ask a ChoiceQuestion, the result returned is the index of
the choice requested, not the value. As such, we need to grab the
value via the index in order to use it.

Fixes #58

When you ask a `ChoiceQuestion`, the result returned is the _index_ of
the choice requested, not the _value_. As such, we need to grab the
value via the index in order to use it.

Fixes #58
@weierophinney weierophinney merged commit 93efac2 into phly:master Nov 7, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
weierophinney added a commit that referenced this pull request Nov 7, 2019
weierophinney added a commit that referenced this pull request Nov 7, 2019
Forward port #62

Conflicts:
	CHANGELOG.md
@weierophinney weierophinney deleted the weierophinney:hotfix/58-remote-usage branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.