Use npm script for building brunch #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you verify that this works on windows? I know we had to invoke node explicitly to cover some windows issues |
|
Verify in that it really works, not "should/supposed to work" :) |
|
definitely! will report back |
|
verified working on windows, given recently pushed commit |
chrismccord
added a commit
that referenced
this pull request
Oct 11, 2015
Use npm script for building brunch
|
<3 <3 <3 |
|
Should we also use this for the brunch watch inside config/dev.exs? José Valim |
|
ah, yes, i missed that usage. i can open a new PR for that later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the installer to utilize an npm run script for running
brunch build.npm run scripts are run with any locally installed bins in the
PATH, so that you can call the executables directly without having to call intonode_modules/...or ask that someone install a dependency globally. This is preferable because the current method of reaching intonode_modules/...is prone to breaking if thebrunchpackage ever changes where it stores the bin, whereas this will always work as long as it defines an executable in itspackage.json.