New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move generators to Ecto 2.0 #1649

Merged
merged 6 commits into from Apr 18, 2016

Conversation

Projects
None yet
3 participants
@josevalim
Member

josevalim commented Apr 17, 2016

No description provided.

Alessandro Mencarini and others added some commits Mar 12, 2016

Change errors to match Ecto nomalised format
As we are changing ecto error messages from strings to tuples (see
elixir-ecto/ecto#1308), this updates Phoenix to be aware of those
changes.

Signed-off-by: José Valim <jose.valim@plataformatec.com.br>

@josevalim josevalim referenced this pull request Apr 17, 2016

Closed

Migrate to Ecto 2.0 #1564

6 of 6 tasks complete

@chrismccord chrismccord merged commit bd4b998 into master Apr 18, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@chrismccord

This comment has been minimized.

Show comment
Hide comment
@chrismccord

chrismccord Apr 18, 2016

Member

<3 <3 <3

Member

chrismccord commented Apr 18, 2016

<3 <3 <3

@philipgiuliani

This comment has been minimized.

Show comment
Hide comment
@philipgiuliani

philipgiuliani May 16, 2016

Contributor

What do you think about another name instead of struct? Credo isn't happy about that, because its a bit unsafe to use struct (defined in Kernel).

[Warning] Parameter `struct` has same name as the `Kernel.struct` function.
Contributor

philipgiuliani commented on priv/templates/phoenix.gen.model/model.ex in 8b560cd May 16, 2016

What do you think about another name instead of struct? Credo isn't happy about that, because its a bit unsafe to use struct (defined in Kernel).

[Warning] Parameter `struct` has same name as the `Kernel.struct` function.

This comment has been minimized.

Show comment
Hide comment
@josevalim

josevalim May 16, 2016

Member
Member

josevalim replied May 16, 2016

@josevalim josevalim deleted the jv-ecto-2 branch Jun 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment