New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace brunch with webpack 4 in the installers #2779

Merged
merged 1 commit into from Mar 2, 2018

Conversation

Projects
None yet
5 participants
@Gazler
Member

Gazler commented Mar 2, 2018

Since brunch hasn't been updated in a while, webpack has been chosen as a replacement.
webpack 4 reduces a lot of the config required, the included configuration is
designed so that the compiled assets act the same way as they did with bruch (js
goes in priv/static/js/app.js and css in priv/static/css/app.js. Any assets
in assets/static are copied over to priv/static.

All references to brunch have been replaced by webpack. The --no-bruch flag is
now --no-webpack.

Stylistically, webpack is written with a lower case "w" - so this has
been used in any comments/documentation.

Replace brunch with webpack 4 in the installers
Since brunch is no longer maintained, webpack has been chosen as a replacement.
webpack 4 reduces a lot of the config required, the included configuration is
designed so that the compiled assets act the same way as they did with bruch (js
goes in `priv/static/js/app.js` and css in `priv/static/css/app.js`. Any assets
in `assets/static` are copied over to `priv/static`.

All references to brunch have been replaced by webpack. The `--no-bruch` flag is
now `--no-webpack`.

Stylistically, webpack is written with a lower case "w" - so this has
been used in any comments/documentation.

@Gazler Gazler requested a review from chrismccord Mar 2, 2018

@Gazler

This comment has been minimized.

Member

Gazler commented Mar 2, 2018

This might need testing on Windows.

@chrismccord chrismccord merged commit 46dd1d5 into master Mar 2, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@chrismccord

This comment has been minimized.

Member

chrismccord commented Mar 2, 2018

❤️❤️❤️🐥🔥

@webdeb

This comment has been minimized.

Contributor

webdeb commented Mar 2, 2018

Wow!

@Gazler Gazler deleted the gr-webpack branch Mar 3, 2018

@drozdzynski

This comment has been minimized.

drozdzynski commented Mar 17, 2018

@Gazler From where you got information about no longer maintained Brunch?

@Gazler

This comment has been minimized.

Member

Gazler commented Mar 17, 2018

@drozdzynski That was poor wording on my part, I had meant to go back and change it before this PR was merged. I have updated my original comment to help clarify this.

It's not brunch specifically (although there hasn't been a huge amount of activity on the brunch main repo either recently), but the libraries and eco-system around it that seem to be lacking in maintenance updated.

@skovmand

This comment has been minimized.

skovmand commented Oct 2, 2018

Have you considered this statement in the extract-text-webpack-plugin repo?
"Since webpack v4 the extract-text-webpack-plugin should not be used for css. Use mini-css-extract-plugin instead."

@Gazler

This comment has been minimized.

Member

Gazler commented Oct 2, 2018

@skovmand Yeah, we changed it in this PR #2831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment