New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow channels to immediately reconnect when the socket does #3141

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@sb8244
Contributor

sb8244 commented Nov 4, 2018

The timer state must be known in order to know if the channel was attempting to rejoin or not. It is
not correct to start a channel rejoin timer if it was not previously running. This involved changing the timer logic up a bit to clear out this.timer when it's done processing

Related to #3139

Allow channels to immediately reconnect when the socket does
The timer state must be known in order to know if the channel was attempting to rejoin or not. It is
not correct to start a channel rejoin timer if it was not previously running.

@chrismccord chrismccord merged commit 3b6bc38 into phoenixframework:master Nov 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chrismccord

This comment has been minimized.

Member

chrismccord commented Nov 7, 2018

❤️❤️❤️🐥🔥

@sb8244 sb8244 deleted the sb8244:sb8244-channel-timer branch Nov 7, 2018

@GrantJamesPowell

This comment has been minimized.

GrantJamesPowell commented Nov 7, 2018

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment