Allow channels to immediately reconnect when the socket does#3141
Merged
chrismccord merged 1 commit intophoenixframework:masterfrom Nov 7, 2018
Merged
Allow channels to immediately reconnect when the socket does#3141chrismccord merged 1 commit intophoenixframework:masterfrom
chrismccord merged 1 commit intophoenixframework:masterfrom
Conversation
The timer state must be known in order to know if the channel was attempting to rejoin or not. It is not correct to start a channel rejoin timer if it was not previously running.
Member
|
❤️❤️❤️🐥🔥 |
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timer state must be known in order to know if the channel was attempting to rejoin or not. It is
not correct to start a channel rejoin timer if it was not previously running. This involved changing the timer logic up a bit to clear out
this.timerwhen it's done processingRelated to #3139