Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Controller.put_flash and Presence.list arities in docs #3232

Merged
merged 1 commit into from Jan 7, 2019
Merged

Fix Controller.put_flash and Presence.list arities in docs #3232

merged 1 commit into from Jan 7, 2019

Conversation

michallepicki
Copy link
Contributor

@michallepicki michallepicki commented Jan 4, 2019

Found warnings when using master ex_doc:

warning: documentation references Phoenix.Presence.list/1 but it doesn't exist or it's listed as @doc false (parsing Phoenix.Presence.get_by_key/3 docs)

warning: documentation references Phoenix.Presence.list/1 but it doesn't exist or it's listed as @doc false (parsing Phoenix.Presence.get_by_key/3 docs)

warning: documentation references Phoenix.Controller.put_flash/2 but it doesn't exist or it's listed as @doc false (parsing contexts docs)

This commit fixes them.

(Yay, these warnings are awesome!)

@Gazler Gazler merged commit dbcfe8e into phoenixframework:master Jan 7, 2019
1 check passed
@Gazler
Copy link
Member

Gazler commented Jan 7, 2019

Thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants