Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references in guides #3251

Merged
merged 4 commits into from Jan 21, 2019
Merged

Fix references in guides #3251

merged 4 commits into from Jan 21, 2019

Conversation

michallepicki
Copy link
Contributor

@michallepicki michallepicki commented Jan 18, 2019

No description provided.

Logger.Backends does not exist at all.
Logger.Config is a private module - the link should not be generated at
all, but that's ex_doc issue
@Gazler Gazler merged commit f63d763 into phoenixframework:master Jan 21, 2019
1 check passed
@Gazler
Copy link
Member

Gazler commented Jan 21, 2019

Thanks <3

Gazler pushed a commit that referenced this pull request Jan 21, 2019
* Remove invalid link to Logger in Contexts guide

Logger.Backends does not exist at all.
Logger.Config is a private module - the link should not be generated at
all, but that's ex_doc issue

* Fix references to ecto_sql modules in guides

* link to recent Elixir modules versions

* link to recent Plug documentation; let ex_doc generate link
Xiaobin0860 added a commit to Xiaobin0860/phoenix that referenced this pull request Feb 16, 2019
* phx/master: (26 commits)
  Support any struct with :endpoint key in helpers
  Inspect body in ConnTest.response/2 (phoenixframework#3267)
  update snippet to agree with latest phx.new (phoenixframework#3277)
  Only enable trim for HTML templates
  Revert reconnect optimizations which introduced regressions. Fixes phoenixframework#3161 (phoenixframework#3272)
  Reword sentence in Controllers guide (phoenixframework#3270)
  update documentation to reflect on function deprecations (phoenixframework#3269)
  Fix warning in presence
  Default log for render errors info should be debug
  Add jason to umbrella ecto deps. Fixes phoenixframework#3263
  Add Elixir Slack community in the help column of the initial default page (phoenixframework#3262)
  Update heroku.md (phoenixframework#3241)
  add JavaPhoenixClient in 3rd party channels client libraries list (phoenixframework#3256)
  fix typespec for put_layout (phoenixframework#3253)
  Add version to umbrellas (mirror Elixir master)
  Fix references in guides (phoenixframework#3251)
  Add $PORT bind step in Heroku deployment guide (phoenixframework#3235)
  update link to mime  types (phoenixframework#3249)
  Add Elixir 1.7 and 1.8 to Travis CI build matrix (phoenixframework#3248)
  Update learning.md (phoenixframework#3247)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants