Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert reconnect optimizations which introduced regressions #3272

Merged
merged 1 commit into from Feb 12, 2019

Conversation

chrismccord
Copy link
Member

@chrismccord chrismccord commented Feb 12, 2019

Fixes #3161

@chrismccord chrismccord changed the title Revert reconnect optimizations which introduced regressions. Fixes #3161 Revert reconnect optimizations which introduced regressions Feb 12, 2019
@parse
Copy link

parse commented Feb 12, 2019

Tested this on our end and it solves the issue (Ping @simpers @malicaspeco)

@chrismccord chrismccord merged commit 0f967ad into master Feb 12, 2019
2 checks passed
@chrismccord chrismccord deleted the cm-revert-reconnect-optimizations branch Feb 12, 2019
Xiaobin0860 added a commit to Xiaobin0860/phoenix that referenced this pull request Feb 16, 2019
* phx/master: (26 commits)
  Support any struct with :endpoint key in helpers
  Inspect body in ConnTest.response/2 (phoenixframework#3267)
  update snippet to agree with latest phx.new (phoenixframework#3277)
  Only enable trim for HTML templates
  Revert reconnect optimizations which introduced regressions. Fixes phoenixframework#3161 (phoenixframework#3272)
  Reword sentence in Controllers guide (phoenixframework#3270)
  update documentation to reflect on function deprecations (phoenixframework#3269)
  Fix warning in presence
  Default log for render errors info should be debug
  Add jason to umbrella ecto deps. Fixes phoenixframework#3263
  Add Elixir Slack community in the help column of the initial default page (phoenixframework#3262)
  Update heroku.md (phoenixframework#3241)
  add JavaPhoenixClient in 3rd party channels client libraries list (phoenixframework#3256)
  fix typespec for put_layout (phoenixframework#3253)
  Add version to umbrellas (mirror Elixir master)
  Fix references in guides (phoenixframework#3251)
  Add $PORT bind step in Heroku deployment guide (phoenixframework#3235)
  update link to mime  types (phoenixframework#3249)
  Add Elixir 1.7 and 1.8 to Travis CI build matrix (phoenixframework#3248)
  Update learning.md (phoenixframework#3247)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants