Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize config/prod.secret.exs #3380

Merged
merged 1 commit into from Apr 19, 2019

Conversation

@josevalim
Copy link
Member

josevalim commented Apr 19, 2019

We have historically stayed away from environment variables
because it was incompatible with releases but now with
Distillery 2 and mix release in Elixir v1.9 this is a
solved problem, so we can push towards those best practices
for new apps.

We have historically stayed away from environment variables
because it was incompatible with releases but now with
Distillery 2 and `mix release` in Elixir v1.9 this is a
solved problem, so we can push towards those best practices
for new apps.
@chrismccord chrismccord merged commit 7c1a6a1 into master Apr 19, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@chrismccord

This comment has been minimized.

Copy link
Member

chrismccord commented Apr 19, 2019

❤️❤️❤️🐥🔥

josevalim added a commit that referenced this pull request Apr 20, 2019
We have historically stayed away from environment variables
because it was incompatible with releases but now with
Distillery 2 and `mix release` in Elixir v1.9 this is a
solved problem, so we can push towards those best practices
for new apps.

Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
@josevalim josevalim deleted the jv-modernize-config branch Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.