-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add phx.gen.auth generator #4077
Add phx.gen.auth generator #4077
Conversation
end | ||
|
||
@tag database: :postgresql | ||
test "has a passing test suite" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be moved inside the describe block above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same applies to the test files, btw. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that. I think I fixed them all in 02e8988.
integration_test/test/code_generation/app_with_defaults_test.exs
Outdated
Show resolved
Hide resolved
@aaronrenner just some minor comments but otherwise it looks great to me! Regarding the guides, we need to do three changes which can be done separately:
EDIT: Once we do step 1, let's also add a link to the guides from the generator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to merge it at your discretion, if you would rather add the guides now or later, it is your call. ❤️
ff10072
to
0190e28
Compare
This adds the
mix phx.gen.auth
task from phx_gen_auth v0.6.0 into phoenix master. The only additional change is to address a test failure caused by some changes tocurrent_path/1
on phoenix master (see aaronrenner/phx_gen_auth#96).This PR is missing the phx.gen.auth overview doc (https://github.com/aaronrenner/phx_gen_auth/blob/master/guides/overview.md). Is that something you'd like as part of this PR and if so, where would be a good place to work this in? We'll also probably want to add this to phoenix's mix tasks guide in a future PR.
Let me if you see anything stylistically that needs to be updated to match the rest of the phoenix codebase or anything else that would be good to change. Thanks!
/cc @josevalim