Repository navigation
Add phx.gen.auth generator - #4077
Conversation
| end | ||
|
|
||
| @tag database: :postgresql | ||
| test "has a passing test suite" do |
There was a problem hiding this comment.
Should this be moved inside the describe block above?
There was a problem hiding this comment.
The same applies to the test files, btw. :)
There was a problem hiding this comment.
Thanks for catching that. I think I fixed them all in 02e8988.
|
@aaronrenner just some minor comments but otherwise it looks great to me! Regarding the guides, we need to do three changes which can be done separately:
EDIT: Once we do step 1, let's also add a link to the guides from the generator. |
josevalim
left a comment
There was a problem hiding this comment.
LGTM! Feel free to merge it at your discretion, if you would rather add the guides now or later, it is your call. ❤️
ff10072 to
0190e28
Compare
This adds the
mix phx.gen.authtask from phx_gen_auth v0.6.0 into phoenix master. The only additional change is to address a test failure caused by some changes tocurrent_path/1on phoenix master (see aaronrenner/phx_gen_auth#96).This PR is missing the phx.gen.auth overview doc (https://github.com/aaronrenner/phx_gen_auth/blob/master/guides/overview.md). Is that something you'd like as part of this PR and if so, where would be a good place to work this in? We'll also probably want to add this to phoenix's mix tasks guide in a future PR.
Let me if you see anything stylistically that needs to be updated to match the rest of the phoenix codebase or anything else that would be good to change. Thanks!
/cc @josevalim