Add fullscreen when viewing the app info

[fmterrorf]

closes #366

Peek.2022-04-12.21-34.mp4

[mcrumm]

Wow thanks @fmterrorf this looks great! Can you please roll back the dist changes tho- for security reasons we won't accept a PR that includes generated assets. Thanks!

[fmterrorf]

@mcrumm I've reverted the changes in dist. I noticed that the package-lock also got changed. Should I revert that as well?

[mcrumm]

@fmterrorf Yes, please do. If it needs to be updated we'll be sure to do so when we bump the build :)

[josevalim]

This is awesome!

I also think we can fully implement this using Phoenix.LiveView.JS and avoid the additional server state. Can you please check/try?

[fmterrorf]

I can definitely just use JS remove/add_class! I'll have a look more tomorrow

[fmterrorf]

Updated it to use JS commands. It looks like this right now:

Peek.2022-04-13.19-31.mp4

[josevalim]

It looks great! One last detail. The new full screen button is shifting the modal header so the title is no longer vertically in the center. Can you please take a look? Here is how it looks today:

[fmterrorf]

@josevalim Thanks for pointing that out! The new commits should line it up properly now

Master

This branch

[fmterrorf]

I'll fix up the test in a few 👀

[josevalim]

@fmterrorf also please don't commit changes to dist, I will do so after nmerging!

[fmterrorf]

Test should be good now. I ran it locally and only got the 1 failure from test/phoenix/live_dashboard/pages/ecto_stats_test.exs:110 because i dont have a mysql container running

[josevalim]

💚 💙 💜 💛 ❤️