Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiveView Lifecycle Hooks #1511

Merged
merged 15 commits into from
Jul 2, 2021
Merged

LiveView Lifecycle Hooks #1511

merged 15 commits into from
Jul 2, 2021

Conversation

mcrumm
Copy link
Member

@mcrumm mcrumm commented Jun 26, 2021

No description provided.

josevalim
josevalim reviewed Jun 26, 2021
View reviewed changes
lib/phoenix_live_view.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Jun 26, 2021
View reviewed changes
lib/phoenix_live_view.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Jun 26, 2021
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I have dropped some minor comments only!

josevalim
josevalim reviewed Jun 28, 2021
View reviewed changes
lib/phoenix_live_view.ex Outdated Show resolved Hide resolved
@chrismccord chrismccord mentioned this pull request Jun 28, 2021
Closed
@mcrumm mcrumm marked this pull request as ready for review June 30, 2021 21:32
josevalim
josevalim reviewed Jul 1, 2021
View reviewed changes
lib/phoenix_live_view.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Jul 1, 2021
View reviewed changes
lib/phoenix_live_view.ex

on_mount {DemoWeb.LiveAuth, :ensure_mounted_current_user}
on_mount DemoWeb.InitAssigns
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide examples of how the actual callback would look like in this case. :)

josevalim
josevalim reviewed Jul 1, 2021
View reviewed changes
lib/phoenix_live_view.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Jul 1, 2021
View reviewed changes
lib/phoenix_live_view.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Jul 1, 2021
View reviewed changes
lib/phoenix_live_view.ex Outdated Show resolved Hide resolved
josevalim
josevalim approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just left some bikesheds on the docs and on the Hook module, other than that, this is good to merge to me!

@chrismccord chrismccord merged commit d4983f8 into master Jul 2, 2021
@chrismccord chrismccord deleted the mc-hooks branch July 2, 2021 10:55
@chrismccord
Copy link
Member

❤️❤️❤️🐥🔥

@mcrumm mcrumm mentioned this pull request Jul 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismccord chrismccord chrismccord left review comments

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcrumm @chrismccord @josevalim