Document LiveView controller example requiring Phoenix controller #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Oct 14, 2021
josevalim
reviewed
Oct 14, 2021
lib/phoenix_live_view/controller.ex
Outdated
| @@ -19,7 +19,7 @@ defmodule Phoenix.LiveView.Controller do | |||
| ## Examples | |||
|
|
|||
| defmodule ThermostatController do | |||
| ... | |||
| use AppWeb, :controller | |||
There was a problem hiding this comment.
I believe the convention is to call those things MyApp.
Suggested change
| use AppWeb, :controller | |
| use MyAppWeb, :controller |
|
Good idea! I have added some suggestions to provide more context to users. |
Co-authored-by: José Valim <jose.valim@gmail.com>
|
Thanks for the suggestions! I found a couple other places where Thanks, Jose, I love your work. |
|
💚 💙 💜 💛 ❤️ |
Zurga
pushed a commit
to Zurga/phoenix_live_view
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not apparent to me that the
Phoenix.LiveView.Controllerrequired thePhoenix.Controller. If you find this minor edit acceptable, it could help someone else.Thank you for sharing this incredible project.