Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use into with a non-empty list as this is deprecated in 1.8.0 #121

Merged

Conversation

Projects
None yet
6 participants
@Gazler
Copy link
Member

commented Jan 25, 2019

See elixir-lang/elixir@6023568

Closes #120

@quolpr

This comment has been minimized.

Copy link

commented Jan 25, 2019

Wow, so fast!

@arjan

This comment has been minimized.

Copy link

commented Feb 2, 2019

Any chance this gets merged soon? Warnings in the test output driving me nuts ;-)

@Gazler Gazler requested a review from chrismccord Feb 4, 2019

@arjan

This comment has been minimized.

Copy link

commented Feb 18, 2019

@chrismccord could you take a look at this, it is a trivial fix.

@princemaple

This comment has been minimized.

Copy link

commented Feb 23, 2019

Sorry about pinging again @chrismccord , this is really taking over the debugging log. If someone could take a look and merge (and make a release 😉) we'd be immensely thankful.

@arjan

This comment has been minimized.

Copy link

commented Feb 23, 2019

Maybe we could ping another maintainer... @josevalim ? 😜

@josevalim josevalim merged commit 316fdd8 into phoenixframework:master Feb 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@josevalim

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

❤️ 💚 💙 💛 💜

@denvaar

This comment has been minimized.

Copy link

commented Feb 24, 2019

Thank you for this update!

@princemaple

This comment has been minimized.

Copy link

commented Feb 24, 2019

Looks like Jose doesn't have the permission to push this one to hex... 😂

@Gazler Gazler deleted the Gazler:fix/deprecation-elixir-1-8-0 branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.