Fixed some unpleasances with SimpleDateFormat and added convenience methods #3

Merged
merged 4 commits into from Jun 29, 2011

Projects

None yet

2 participants

@michael-o

Hi Paul,

just started using your lib in my second app and fixed some bugs and missing features:

  1. The JDK has some bugs in the localized patterns, see log messages. So I reverted to generic patterns
  2. I badly needed to check for the absence of opts and non-opt arguments
@pholser
Owner
pholser commented Jun 29, 2011

Thanks! Wasn't aware of all the problems with localized date/time patterns.

I'm inclined to leave out OptionSet.hasNonOptionArguments() -- not sure that it communicates that much more clearly than OptionSet.nonOptionArguments().isEmpty(). I'll definitely roll in the other changes.

@michael-o

That's great. Thanks for the quick response.

@pholser pholser merged commit ebd2223 into pholser:master Jun 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment