New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-update support #232

Closed
mwbrooks opened this Issue Dec 3, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@mwbrooks
Member

mwbrooks commented Dec 3, 2014

We should consider adding auto-update support. When a newer version of the application is available, we can download it, install it, and reopen the application automatically. This is pretty standard in most modern desktop apps.

By the looks of it, node-webkit defers this responsibility to: https://github.com/edjafarov/node-webkit-updater

It looks like it's an active project that's well designed and easy to use. I'm not sure how well it works though.

@mwbrooks mwbrooks added the enhancement label Dec 3, 2014

@hermwong hermwong added this to the Post 1.0 Release enhancements milestone Dec 4, 2014

@hermwong hermwong self-assigned this Dec 4, 2014

@hermwong hermwong modified the milestones: Post 1.0 Release enhancements, 0.1.2 Beta Dec 12, 2014

@hermwong hermwong modified the milestones: 0.1.3 Beta, 0.1.2 Beta Feb 23, 2015

hermwong added a commit that referenced this issue Feb 26, 2015

[#232] modified update button on the update app dialog to download th…
…e newest version of pg-desktop when a new version is available

@hermwong hermwong modified the milestones: 0.1.3 Beta, 0.1.4 Beta Mar 12, 2015

@hermwong hermwong modified the milestones: 0.1.4 Beta, 0.1.5 Beta Apr 2, 2015

@hollyschinsky

This comment has been minimized.

Show comment
Hide comment
@hollyschinsky

hollyschinsky Apr 6, 2015

Contributor

Getting some issues with auto-update when going from 0.1.3 to the latest version (0.1.4). Tried on two machines, with the following results:

When I run this on a laptop running Yosemite (10.10.2), the green Update button downloads the app to a temp folder (to Macintosh HD ▸ private ▸ var ▸ folders ▸ _x ▸ s6wsj5sd659d0fp45dbnyd_m0000gn ▸ T ▸ PhoneGap-Desktop-Beta-0.1.4-mac) but doesn't complete the installation when I click Restart. It appears to try to open and run it but stays blank then closes on it's own.

When I tried on another laptop running OS X 10.9.2 it downloads the file (to Macintosh HD ▸ private ▸ var ▸ folders ▸ _x ▸ s6wsj5sd659d0fp45dbnyd_m0000gn ▸ T ▸ PhoneGap-Desktop-Beta-0.1.4-mac) and opens it when I click Restart, but it doesn't move it to the Applications folder or overwrite the old version so I would have to go find it again to open it otherwise I still get the old one.

Contributor

hollyschinsky commented Apr 6, 2015

Getting some issues with auto-update when going from 0.1.3 to the latest version (0.1.4). Tried on two machines, with the following results:

When I run this on a laptop running Yosemite (10.10.2), the green Update button downloads the app to a temp folder (to Macintosh HD ▸ private ▸ var ▸ folders ▸ _x ▸ s6wsj5sd659d0fp45dbnyd_m0000gn ▸ T ▸ PhoneGap-Desktop-Beta-0.1.4-mac) but doesn't complete the installation when I click Restart. It appears to try to open and run it but stays blank then closes on it's own.

When I tried on another laptop running OS X 10.9.2 it downloads the file (to Macintosh HD ▸ private ▸ var ▸ folders ▸ _x ▸ s6wsj5sd659d0fp45dbnyd_m0000gn ▸ T ▸ PhoneGap-Desktop-Beta-0.1.4-mac) and opens it when I click Restart, but it doesn't move it to the Applications folder or overwrite the old version so I would have to go find it again to open it otherwise I still get the old one.

@hermwong hermwong reopened this Apr 6, 2015

@hermwong

This comment has been minimized.

Show comment
Hide comment
@hermwong

hermwong Apr 7, 2015

Member

It looks like the update is being properly downloaded and unzipped in the temp folder, but when the restart happens the PG-Desktop opens with a blank screen and the updated version doesn't seem to get copied over to the Applications folder (tested on Yosemite OSX 10.10.2).

When the restart is triggered from the Restart button it tries to run the updated version of PG-Desktop from the temp folder. If I navigate to the temp folder in Finder and click on the downloaded update the PG-Desktop does load properly. I still need to determine reason for the blank screen when the restart is triggered from the PG-Desktop.

Basically there are 2 issues that are causing the auto-update to fail:

  1. Restart doesn't work when triggered from PG-Desktop
  2. Updated PG-Desktop isn't being copied over to the Applications folder.
Member

hermwong commented Apr 7, 2015

It looks like the update is being properly downloaded and unzipped in the temp folder, but when the restart happens the PG-Desktop opens with a blank screen and the updated version doesn't seem to get copied over to the Applications folder (tested on Yosemite OSX 10.10.2).

When the restart is triggered from the Restart button it tries to run the updated version of PG-Desktop from the temp folder. If I navigate to the temp folder in Finder and click on the downloaded update the PG-Desktop does load properly. I still need to determine reason for the blank screen when the restart is triggered from the PG-Desktop.

Basically there are 2 issues that are causing the auto-update to fail:

  1. Restart doesn't work when triggered from PG-Desktop
  2. Updated PG-Desktop isn't being copied over to the Applications folder.

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Apr 8, 2015

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Apr 8, 2015

[#232] modified update button on the update app dialog to download th…
…e newest version of pg-desktop when a new version is available

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Apr 8, 2015

@hermwong

This comment has been minimized.

Show comment
Hide comment
@hermwong

hermwong Apr 9, 2015

Member

Discovered that the update will fail if the user goes through the auto-update workflow which fails the restart and then attempts to auto-update again when they manually restart.

It seems that there is an issue / conflict when attempting to re-download the update when the user attempts the second auto-update because the zip already exists in the temp folder.

Member

hermwong commented Apr 9, 2015

Discovered that the update will fail if the user goes through the auto-update workflow which fails the restart and then attempts to auto-update again when they manually restart.

It seems that there is an issue / conflict when attempting to re-download the update when the user attempts the second auto-update because the zip already exists in the temp folder.

hermwong added a commit that referenced this issue Apr 15, 2015

hermwong added a commit that referenced this issue Apr 23, 2015

@hermwong hermwong closed this Apr 23, 2015

hermwong added a commit that referenced this issue Apr 27, 2015

hermwong added a commit that referenced this issue Apr 27, 2015

hermwong added a commit that referenced this issue Oct 26, 2016

[#232] modified update button on the update app dialog to download th…
…e newest version of pg-desktop when a new version is available

hermwong added a commit that referenced this issue Oct 26, 2016

hermwong added a commit that referenced this issue Oct 26, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

[#232] modified update button on the update app dialog to download th…
…e newest version of pg-desktop when a new version is available

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

[#232] modified update button on the update app dialog to download th…
…e newest version of pg-desktop when a new version is available

Former-commit-id: 168f110

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

[#232] modified update button on the update app dialog to download th…
…e newest version of pg-desktop when a new version is available

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

[#232] modified update button on the update app dialog to download th…
…e newest version of pg-desktop when a new version is available

Former-commit-id: 168f110

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

[#232] modified update button on the update app dialog to download th…
…e newest version of pg-desktop when a new version is available

Former-commit-id: cad0f13

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment