New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect-phonegap 0.14.7 doesn't seem to return an IP address #287

Closed
hermwong opened this Issue Jan 31, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@hermwong
Member

hermwong commented Jan 31, 2015

PhoneGap Desktop using connect-phonegap 0.14.3:

screen shot 2015-01-30 at 3 51 29 pm

PhoneGap Desktop using connect-phonegap 0.14.7:

screen shot 2015-01-30 at 3 56 14 pm

The serverOnlineState function receives a data object returned from the complete event of the connect-phonegap.listen API which is parsed to display the IP address within the PhoneGap Desktop App.

With the update to connect-phonegap 0.14.7, the data object is returning the string unknown as the data.address property.

screen shot 2015-01-30 at 4 09 13 pm

@hermwong hermwong self-assigned this Jan 31, 2015

@hermwong hermwong added this to the 0.1.2 Beta milestone Jan 31, 2015

@timkim

This comment has been minimized.

Show comment
Hide comment
@timkim

timkim Jan 31, 2015

Ya, I found something similar with the last few releases as well. Here's the issue I logged: phonegap/connect-phonegap#107

I think it has to do with some of the commits introduced in 0.14.6 with some of the changes to the util/ip.js.

timkim commented Jan 31, 2015

Ya, I found something similar with the last few releases as well. Here's the issue I logged: phonegap/connect-phonegap#107

I think it has to do with some of the commits introduced in 0.14.6 with some of the changes to the util/ip.js.

@hermwong hermwong added the bug label Jan 31, 2015

@mwbrooks

This comment has been minimized.

Show comment
Hide comment
@mwbrooks

mwbrooks Feb 3, 2015

Member

Published as connect-phonegap@0.14.8

I wasn't able to recreate the issue, but I've added additional steps to look up the IP address. Let me know how it goes.

Member

mwbrooks commented Feb 3, 2015

Published as connect-phonegap@0.14.8

I wasn't able to recreate the issue, but I've added additional steps to look up the IP address. Let me know how it goes.

@StevenHu

This comment has been minimized.

Show comment
Hide comment
@StevenHu

StevenHu Feb 3, 2015

How do I turn off all these notifications?

On 2/2/2015 4:24 PM, Michael Brooks wrote:

Published as |connect-phonegap@0.14.8|

I wasn't able to recreate the issue, but I've added additional steps
to look up the IP address. Let me know how it goes.


Reply to this email directly or view it on GitHub
#287 (comment).

StevenHu commented Feb 3, 2015

How do I turn off all these notifications?

On 2/2/2015 4:24 PM, Michael Brooks wrote:

Published as |connect-phonegap@0.14.8|

I wasn't able to recreate the issue, but I've added additional steps
to look up the IP address. Let me know how it goes.


Reply to this email directly or view it on GitHub
#287 (comment).

@mwbrooks

This comment has been minimized.

Show comment
Hide comment
@mwbrooks

mwbrooks Feb 3, 2015

Member

@StevenHu can choose to unwatch or ignore the repository's notifications:
screen shot 2015-02-02 at 5 46 57 pm

Member

mwbrooks commented Feb 3, 2015

@StevenHu can choose to unwatch or ignore the repository's notifications:
screen shot 2015-02-02 at 5 46 57 pm

@StevenHu

This comment has been minimized.

Show comment
Hide comment
@StevenHu

StevenHu Feb 3, 2015

Thank you. I had Ignoring set and was still receiving notifications.

On 2/2/2015 5:47 PM, Michael Brooks wrote:

@StevenHu https://github.com/StevenHu can choose to unwatch or
ignore the repository's notifications:
screen shot 2015-02-02 at 5 46 57 pm
https://cloud.githubusercontent.com/assets/21328/6012979/90120fc8-ab03-11e4-82ac-15700859cfce.png


Reply to this email directly or view it on GitHub
#287 (comment).

StevenHu commented Feb 3, 2015

Thank you. I had Ignoring set and was still receiving notifications.

On 2/2/2015 5:47 PM, Michael Brooks wrote:

@StevenHu https://github.com/StevenHu can choose to unwatch or
ignore the repository's notifications:
screen shot 2015-02-02 at 5 46 57 pm
https://cloud.githubusercontent.com/assets/21328/6012979/90120fc8-ab03-11e4-82ac-15700859cfce.png


Reply to this email directly or view it on GitHub
#287 (comment).

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment