New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS init option type #180

Closed
fredgalvao opened this Issue Sep 30, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@fredgalvao
Collaborator

fredgalvao commented Sep 30, 2015

So, all examples and code samples call .init() with string options passed on the iOS part, but they're specified as Boolean on README.md. Checking source code I can see that both ways are handled, but shouldn't we either

  • pick one way and go with it
    or
  • be explicit that both ways work
    ?

@macdonst macdonst added the docs label Oct 1, 2015

@macdonst

This comment has been minimized.

Show comment
Hide comment
@macdonst

macdonst Oct 1, 2015

Member

@fredgalvao feel free to update the docs on this one.

Member

macdonst commented Oct 1, 2015

@fredgalvao feel free to update the docs on this one.

@fredgalvao

This comment has been minimized.

Show comment
Hide comment
@fredgalvao

fredgalvao Oct 1, 2015

Collaborator

@macdonst Which approach is the desired one though?

Collaborator

fredgalvao commented Oct 1, 2015

@macdonst Which approach is the desired one though?

@macdonst

This comment has been minimized.

Show comment
Hide comment
@macdonst

macdonst Oct 1, 2015

Member

@fredgalvao I believe in defensive programming. So if I'm expecting a boolean true I also except the String "true" to be valid. Same thing for false.

Member

macdonst commented Oct 1, 2015

@fredgalvao I believe in defensive programming. So if I'm expecting a boolean true I also except the String "true" to be valid. Same thing for false.

@macdonst macdonst closed this in #191 Oct 1, 2015

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Jun 5, 2018

This thread has been automatically locked.

lock bot commented Jun 5, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.