New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Not able to schedule local notification after adding the plugin #183

Closed
sparsh0611 opened this Issue Sep 30, 2015 · 10 comments

Comments

Projects
None yet
5 participants
@sparsh0611

Even when a local notification is scheduled, didRegisterForRemoteNotificationsWithDeviceToken method of PushPlugin.m gets called and returns an error "Invalid callback id received by sendPluginResult". Because of this, local notification is not scheduled either.
The plugin used for local notification is -
https://github.com/katzer/cordova-plugin-local-notifications.git

@fredgalvao

This comment has been minimized.

Show comment
Hide comment
@fredgalvao

fredgalvao Sep 30, 2015

Collaborator

If this means the cordova-plugin-local-notification plugin doesn't work well with phonegap-plugin-push, I +1 on fixing it. I was counting on being able to use both plugins on my project.

Collaborator

fredgalvao commented Sep 30, 2015

If this means the cordova-plugin-local-notification plugin doesn't work well with phonegap-plugin-push, I +1 on fixing it. I was counting on being able to use both plugins on my project.

@macdonst

This comment has been minimized.

Show comment
Hide comment
@macdonst

macdonst Oct 1, 2015

Member

@sparsh0611 interesting, did you open a similar bug on Local Notifications and link to this one?

Member

macdonst commented Oct 1, 2015

@sparsh0611 interesting, did you open a similar bug on Local Notifications and link to this one?

@sparsh0611

This comment has been minimized.

Show comment
Hide comment
@sparsh0611

sparsh0611 Oct 3, 2015

@macdonst No, since the problem started after the previous PushPlugin was deprecated and I switched to this one, I haven't opened the bug on Local Notifications.
Edit: I have opened a bug on local notification too now. It can be found here.

@macdonst No, since the problem started after the previous PushPlugin was deprecated and I switched to this one, I haven't opened the bug on Local Notifications.
Edit: I have opened a bug on local notification too now. It can be found here.

@macdonst

This comment has been minimized.

Show comment
Hide comment
@macdonst

macdonst Oct 3, 2015

Member

@sparsh0611 kk, thx. It's weird that it would pop up now as the iOS code is nearly identical to the old plugin.

Member

macdonst commented Oct 3, 2015

@sparsh0611 kk, thx. It's weird that it would pop up now as the iOS code is nearly identical to the old plugin.

@macdonst macdonst added the retest label Oct 3, 2015

@sparsh0611

This comment has been minimized.

Show comment
Hide comment
@sparsh0611

sparsh0611 Oct 6, 2015

@macdonst I'm really grateful for your quick response and all the help. I see that you have added the retest label too. But, my business client is continuously asking me about the progress and also when the issue will be resolved. I'll be really thankful if you could let me know the progress or if you have identified the issue. Thanks.

@macdonst I'm really grateful for your quick response and all the help. I see that you have added the retest label too. But, my business client is continuously asking me about the progress and also when the issue will be resolved. I'll be really thankful if you could let me know the progress or if you have identified the issue. Thanks.

@dnish

This comment has been minimized.

Show comment
Hide comment
@dnish

dnish Oct 8, 2015

Same problem here with Android, it breaks the building when I use both plugins in my project.

dnish commented Oct 8, 2015

Same problem here with Android, it breaks the building when I use both plugins in my project.

@macdonst

This comment has been minimized.

Show comment
Hide comment
@macdonst

macdonst Oct 8, 2015

Member

@dnish Go +1 this PR on the local notification plugin as it fixes your issue: katzer/cordova-plugin-local-notifications#697

Member

macdonst commented Oct 8, 2015

@dnish Go +1 this PR on the local notification plugin as it fixes your issue: katzer/cordova-plugin-local-notifications#697

EdMcBane added a commit to optionfactory/phonegap-plugin-push that referenced this issue Oct 10, 2015

Avoid breaking cordova-plugin-local-notifications
Conflicting implementation of didRegisterUserNotificationSettings
prevents cordova-local-notifications-plugin from being notified of success.
emoving it fixes the problem as it was redundant (simply calls
registerForRemoteNotifications, which is called anyway from PushPlugin:init
right after registerUserNotificationSettings).

Fixes phonegap/phonegap-plugin-push/issues/183 and
katzer/cordova-plugin-local-notifications/issues/695

@macdonst macdonst closed this in #215 Oct 10, 2015

@sparsh0611

This comment has been minimized.

Show comment
Hide comment
@sparsh0611

sparsh0611 Oct 12, 2015

Thanks @EdMcBane for the solution and @macdonst for the quick merge!

Thanks @EdMcBane for the solution and @macdonst for the quick merge!

@katzer

This comment has been minimized.

Show comment
Hide comment

katzer commented Dec 2, 2015

👍

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Jun 5, 2018

This thread has been automatically locked.

lock bot commented Jun 5, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.