Use Google's InstanceID API #188

Closed
macdonst opened this Issue Oct 1, 2015 · 14 comments

Projects

None yet

5 participants

@macdonst macdonst added the enhancement label Oct 1, 2015
@macdonst macdonst self-assigned this Oct 1, 2015
@macdonst macdonst added this to the Release 1.4.0 milestone Oct 1, 2015
@bhaveshgohel

๐Ÿ‘

@bau720123

if could
well..that will really awesome!!!

@miraculixx

๐Ÿ‘

To add some perspective -- this is not only an awesome feature but a requirement by Google:

According to this, the gcm.register is deprecated since May 2015:

GCM register() is deprecated starting May 28, 2015. New app development should use the Instance ID API to handle the creation, rotation, and updating of registration tokens.

While there do not seem to be direct implications (it still works), it would be prudent to plan for migration for the day will come when GCM stops accepting new register() calls.

@macdonst
Member
macdonst commented Oct 5, 2015

@miraculixx Agreed, that's why I'm working on it. ๐Ÿ˜บ

@miraculixx

@macdonst glad to hear ๐Ÿ‘ thanks

@macdonst
Member
macdonst commented Oct 6, 2015

Anyone who wants to test it can check out branch issue188. It seems to be working just fine but I need to do more testing.

@macdonst macdonst added a commit that referenced this issue Oct 12, 2015
@macdonst macdonst Issue #188: Use Google's InstanceID API
Remove gcm.jar
Implement GCM Clould Messaging
Implement Token Refresh Listener
Update Android compilation instructions
a69b596
@macdonst
Member

Fix committed will be official in 1.4.0 release.

@macdonst macdonst closed this Oct 12, 2015
@bhaveshgohel

Thanks @macdonst ! ๐Ÿ‘
Can you please also update the README.md file to reflect the changes on how to use it. ๐Ÿ˜ƒ

@bau720123

+1

@macdonst
Member

@bhaveshgohel I already did under Android compilation. No changes to JS code are necessary.

@bhaveshgohel

Ohh... Thanks @macdonst! ๐Ÿ˜ƒ

@jayj
jayj commented Oct 12, 2015

It added the "Find accounts on the device" Contact permission. What is that permission used for, if it's used?

@macdonst
Member

@jayj Hmm...that is Google Play Services adding that. Lemme see if I can make that smaller.

@smdvdsn smdvdsn added a commit to smdvdsn/phonegap-plugin-push that referenced this issue Oct 18, 2015
@smdvdsn smdvdsn Fixes for using new GcmReceiver code
Replace intent category "com.example.gcm" with $PACKAGE_NAME in plugin.xml.
Change play services dependancy to more specific play-services-gcm

update issue #188
6a8aaa5
@macdonst
Member

@jayj I just merged a PR from contributor @smdvdsn that should remove the need for the "Find accounts on device" permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment