This repository was archived by the owner on Apr 29, 2021. It is now read-only.
Refactored iOS DatePicker plugin#363
Merged
Merged
Conversation
…gation and memory management
…returns the date to the PG JS client
…thod for the ActionSheet that accepts its dependencies via DI. All date handling is now internationally recognised ISO. DatePicker will default to UIDatePickerModeDateAndTime unless specified otherwise. All memory is managed properly, making DatePicker plugin play nice in iOS (without ARC)
shazron
added a commit
that referenced
this pull request
Feb 22, 2012
Refactored iOS DatePicker plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major refactor of the iOS DatePicker plugin to make it play nice with iOS. The previous version was not implementing the standard Objective-C patterns for memory management or delegation. This refactor provides the following;