Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Improve childbrowser API consistency between Android and iOS #427

Merged
merged 2 commits into from

2 participants

@cewing

for complete API consistency the 'install' method should return the browser object. Otherwise the result of the same function in each api is different.

@macdonst macdonst merged commit 6b0c84b into phonegap:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 29, 2012
  1. @cewing
  2. @cewing

    install function should also be defined on the ChildBrowser, not the …

    cewing authored
    …prototype, for complete consistency with iOS API
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  Android/ChildBrowser/www/childbrowser.js
View
3  Android/ChildBrowser/www/childbrowser.js
@@ -77,7 +77,8 @@ ChildBrowser.prototype._onError = function(data) {
/**
* Maintain API consistency with iOS
*/
-ChildBrowser.prototype.install = function(){
+ChildBrowser.install = function(){
+ return window.plugins.childBrowser;
};
/**
Something went wrong with that request. Please try again.