Skip to content

[WP] This addition will ensure Apps developed using ChildBrowser aren't rejected from MarketPlace. #791

Closed
wants to merge 3 commits into from

4 participants

@bhargavgolla

This edit will make sure the icons change according to the theme of phone. One has to replace with one's app's default namespace (which can be found in properties). Will make a ReadMe for better description.

bhargavgolla added some commits Sep 12, 2012
@bhargavgolla bhargavgolla This will get appbar icons based on theme
This edit will make sure the icons change according to the theme of phone. One has to replace <app_name> with one's app's default namespace (which can be found in properties).
dc292df
@bhargavgolla bhargavgolla Added README for better understanding of usage. The images in Images/…
… folder are distributed for free by Microsoft wih its SDK.
44c3a90
@bhargavgolla bhargavgolla commented on the diff Sep 12, 2012
WindowsPhone/ChildBrowser/ChildBrowserCommand.cs
@@ -72,12 +75,29 @@ public void showWebPage(string options)
}
ApplicationBar bar = new ApplicationBar();
- bar.BackgroundColor = Colors.Black;
+ if ((Visibility)App.Current.Resources["PhoneDarkThemeVisibility"] == Visibility.Visible)
@bhargavgolla
bhargavgolla added a note Sep 12, 2012

This and the other similar code lines will make sure that the images in bottom bar change according to theme. My app has been rejected by Marketplace for not sticking to their clause "5.5.2" (http://msdn.microsoft.com/en-us/library/hh184840(v=vs.92).aspx). It should also be noted that ChildBrowser doesn't follow requirement 5.2.4 (usage of Back Button) also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@devgeeks devgeeks reopened this Nov 26, 2012
@shazron
PhoneGap member
shazron commented Nov 4, 2013

This repo has been deprecated and will not be actively maintained - no pull requests nor any other issues will be worked on. The previous source currently exists in the DEPRECATED branch, and may be removed at a future date.
Migration path, see: https://github.com/phonegap/phonegap-plugins/blob/master/README.md

@shazron shazron closed this Nov 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.