Guidance added to config.xml #43

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mwbrooks
Member

Hey @gregorypratt

I've let this pull request slip through the cracks and it looks like it's no longer on your public GitHub repository.

There's a lot of good content in the pull request. Would you mind adding it back? Otherwise I can put it together and reference you.

If you add it back, it would be best to:

  • create a branch called pull-43
  • make your commit message reference this pull request `git commit -am "[#43] Guidance added to config.xml"
  • push the branch git push origin pull-43

I'm unsure if GitHub can auto-pull those into this comment, but worst case you can just reference the branch here.

Thanks!
Michael

@gregorypratt
Contributor

I have no idea if I've done any of that right, not the best GitHub user! If its not feel free to simply put it together and reference me instead.

@mwbrooks mwbrooks added a commit to mwbrooks/phonegap-start that referenced this pull request Mar 15, 2013
@gregorypratt @mwbrooks gregorypratt + mwbrooks [#43] Guidance added to config.xml 288bbaa
@mwbrooks mwbrooks added a commit to mwbrooks/phonegap-start that referenced this pull request Mar 15, 2013
@mwbrooks mwbrooks [#43] Reformat the config.xml comments. df43d3b
@mwbrooks mwbrooks added a commit to mwbrooks/phonegap-start that referenced this pull request Mar 15, 2013
@mwbrooks mwbrooks [#43] Use current version of PhoneGap. f09c115
@mwbrooks
Member

Hey @gregorypratt

Looks awesome man and you did the pull request correct. It's typically best practice to create a topic branch for each pull request (which you did as pull-43). That way you can keep your master up-to-date with phonegap's master without having your pending pull request conflict.

Anyways, comments look great. I added another two commits for a little clean up and to correct the PhoneGap version (PG/Build only supports 2.3.0 at the moment).

Thanks a ton for putting this together!
Michael

@mwbrooks mwbrooks closed this Mar 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment