Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@phosphor-icons/vue/compact significantly increases the build time #39

Open
domin-mnd opened this issue Oct 7, 2023 · 3 comments
Open
Labels
bug Something isn't working

Comments

@domin-mnd
Copy link

🐛 The bug

Compact bundle significantly increases the build time. That being said, the import cost for the bundle is 3.8M:

Import cost

As mentioned in v2.1.4 changelog compact scope bundles all files in a single file aiming to fix the EMFILE error.

Is there any other way of avoiding Error: EMFILE: too many open files... error as in #35 besides using compact scope?

🛠️ To reproduce

Build screenshot

🌈 Expected behaviour

A proposed solution would be exporting per-file icons as in:

import PhHouse from "@phosphor-icons/vue/icons/PhHouse.vue"

ℹ️ Additional context

No response

@domin-mnd domin-mnd added the bug Something isn't working label Oct 7, 2023
@vedmant
Copy link

vedmant commented Feb 29, 2024

+1 I have the same issue, having something like import PhHouse from "@phosphor-icons/vue/icons/PhHouse.vue" will be the best solution

@mikehwagz
Copy link

mikehwagz commented Jun 7, 2024

I am also seeing longer build times after moving to the compact build in an attempt to avoid Error: EMFILE: too many open files... from #35

Builds for this project on vercel went from around 1 minute, to over 7 minutes:
image

@vedmant
Copy link

vedmant commented Jun 26, 2024

I ended up importing icons like this:

import PhList from '~/node_modules/@phosphor-icons/vue/dist/icons/PhList.vue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants